-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim passwords #573
Comments
Hi @elsirion, In PR fedimint/fedimint#6253, backend logic was added to remove leading and trailing whitespace from passwords. I propose replicating this in the frontend for consistency and to provide immediate feedback to users. Should we also include validations for password strength (e.g., minimum 12 characters, at least one uppercase letter, one lowercase letter, one number, and one special character) with clear error messages to guide users? |
I don't think that's necessary since the UI generates a password for the user by default. If you overwrite that we could just show a warning in general, but seems out-of-scope here. The trimming was mostly about the case when a user enters it again iirc. |
WIP 👍 |
Fixed by #589 |
Handle errors when submitting invalid passwords. Idk if that's being done rn. fedimint/fedimint#6253
The text was updated successfully, but these errors were encountered: