Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX review #23

Open
bkabrda opened this issue Jul 26, 2017 · 2 comments
Open

UX review #23

bkabrda opened this issue Jul 26, 2017 · 2 comments

Comments

@bkabrda
Copy link
Contributor

bkabrda commented Jul 26, 2017

This is a proposal created in reaction to [1].

As a user of MTF, I would ideally like to just run a single command, let's call it mtf, in the module directory and everything would just work. The approach proposed in [1] is too complex and somewhat clumsy from user perspective.

The mtf command could work like this:

  • The config.yaml file would contain default list of modules (i.e. the current MODULE argument) which to test against (e.g. ["docker", "rpm"])
  • User would run mtf.
    • This would first invoke the functionality currently covered by mtf-generator
    • And then it would invoke the python -m avocado ... part.
  • Furthermore, mtf could accept various arguments, such as override for the set of modules which to test against (i.e. the current MODULE argument), subset of test files to run etc.

If the user wants to create a Makefile, they would just put mtf --some-options in it and they'd be done with that. They wouldn't need to create unnecessary Makefiles, which would mostly contain the same lines for every module.

Does this sound reasonable? I believe it would greatly improve UX to have this.

[1] http://modularity-testing-framework.readthedocs.io/en/latest/user_guide/index.html

@phracek
Copy link
Member

phracek commented Jul 27, 2017

Make sense to me. Keep it simple.

The config.yaml file would contain default list of modules

Can you please explain it a bit more? modulemd.yaml file contains all default list of modules.

If the user wants to create a Makefile, they would just put mtf --some-options in it and they'd be done with that. They wouldn't need to create unnecessary Makefiles, which would mostly contain the same lines for every module.

The Makefile was present because of automation tasks. Just run make test and not mtf.
I guess, it is more logical.
But I agree with you, creating Makefiles is painful for first time when you play with modules / containers.

Does this sound reasonable? I believe it would greatly improve UX to have this.
[1] http://modularity-testing-framework.readthedocs.io/en/latest/user_guide/index.html

+1

@bkabrda
Copy link
Contributor Author

bkabrda commented Jul 27, 2017

Can you please explain it a bit more? modulemd.yaml file contains all default list of modules.

I meant this simply as a replacement for what was previously in the Makefile. In other words, if currently a Makefile's test section says that the module should be tested for RPM and Docker, then that's what should be possible to put into the config (I think the term "module" is overloaded in this sense, hence the misunderstanding).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants