HowToContribute

Contributing

If you are interested in Fedora SELinux policy development, feel free to contact us on the

• Fedora SELinux Policy GitHub
• Fedora SELinux Policy Contrib GitHub

For more detail questions, ideas and bugs, you can use

• Fedora SELinux mailing list
• Red Hat Bugzilla
• #fedora-selinux on irc.freenode.net

or upstream channels

• Reference Policy GitHub
• Reference Policy mailing list
• #selinux on irc.freenode.net

Fedora SELinux policy changes should be submitted by pull requests on GitHub.

Patches

When submitting patches against Fedora Policy Github, try to follow this advice:

• Make sure you create a new pull request against up-to-date repositories.
• Do not increase the version numbers in the policy_module() lines.
• Make logical and small changes per commit.
• More commits can be a part of one pull request.
• If possible, try to avoid disjoint changes to different modules in a single commit.
• Proposed changes should not break anything.
• Proposed changes should be
• tested
• commented
• compilable

For additional details, where/how we do distro packaging see Packaging section on this wiki.

Patches - real example

The following example show you how to submit a pull request for lircd policy against rawhide branch.

1. Go to https://github.com/fedora-selinux/selinux-policy-contrib.

2. Fork the project using Fork button.

3. Use a git address of your cloned repository, eg. git@github.com:mgrepl/selinux-policy-contrib.git to clone the repository to your local system.

    $ git clone  git@github.com:mgrepl/selinux-policy-contrib.git 
   
    $ cd selinux-policy-contrib
   

4. Set the original project repository as a remote with SELinuxFedoraPolicy name and fetch it.

    $ git remote add SELinuxFedoraPolicy git@github.com:fedora-selinux/selinux-policy-contrib.git
   
    $ git fetch SELinuxFedoraPolicy
   

5. Create a feature branch based on SELinuxFedoraPolicy/rawhide branch.

    $ git checkout -t SELinuxFedoraPolicy/rawhide -b rawhide-lircd
   

6. Edit lircd.te file.

            $ git diff
            diff --git a/lircd.te b/lircd.te
            index 62ca3e4..eeaa01c 100644
            --- a/lircd.te
            +++ b/lircd.te
            @@ -68,6 +68,8 @@ term_use_ptmx(lircd_t)
             term_use_usb_ttys(lircd_t)
             term_use_unallocated_ttys(lircd_t)
   
            +auth_read_passwd(lircd_t)
   

7. Commit and push changes.

            $ git add -p
   
            $ git commit
   
            $ git push origin HEAD
   

8. Go to your cloned project page on GitHub, choose your feature branch (rawhide-lircd) and click on "Compare & pull request" button. Choose rawhide for fedora-selinux/selinux-policy-contrib, check your changes, add your comment and click on "Create pull request" button.