Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative links not rendering correctly #15

Open
LimeBlast opened this issue Apr 3, 2019 · 3 comments
Open

Relative links not rendering correctly #15

LimeBlast opened this issue Apr 3, 2019 · 3 comments

Comments

@LimeBlast
Copy link

LimeBlast commented Apr 3, 2019

I've forked a copy of the OpenStreetmap pluto project (https://github.com/WorcSource/blogs.worcestersource.club), but I'm having trouble with one of the feeds.

The issue is none of the relative link to images or other pages within the post are pointing to the originating blog, and instead are pointing locally, as you can see here: https://nostalgic-dubinsky-598971.netlify.com/ (note the "I made a box" post).

The feed in question is here: https://maker.limeblast.co.uk/feed.xml and works perfectly fine on a Planet Venus site that uses it (https://planet.birmingham.io/) , but not on the pluto site I'm trying to use.

The feed itself is generated Jekyll Feed, the devs of which suggest is working as intended because they use an xml:base element (jekyll/jekyll-feed#260)

I'm hoping you can help me resolve this issue. Thank you.

@geraldb
Copy link
Member

geraldb commented Apr 3, 2019

@LimeBlast Thanks for trying pluto. I'm sorry to tell you that this looks like a missing feature. With a custom ruby filter (that is, search and replace) this should just be a couple of lines for a "quick and dirty" fix / workaround. Cheers. Prost.

PS: For some feed filter examples, see https://github.com/feedparser/feedfilter.

@LimeBlast
Copy link
Author

If I wanted to fix this properly (i.e. to submit a pull request for inclusion in the core), where should I be looking? I.e. which files within this repository are responsible for outputting the content to the page?

Thanks.

@geraldb
Copy link
Member

geraldb commented Apr 10, 2019

Pluto is designed on purpose to have "programmable" templates and "plugins", that is, ruby scripts. Try to add a filter (ruby script / helper) to your template. To be honest I don't know what's the "best" way off the top of my head (without "deeper" research). The ultimate version (of course) would be adding the "fix" to the feedparser library (I assume every format is different :-), see https://github.com/feedparser/feedparser. You might check what the alternate feedjira library is doing or some other feedreader / planets.

PS: To answer "which files within this repository are responsible for outputting the content to the page" see https://github.com/feedreader/pluto/blob/master/pluto-merge/lib/pluto/merge/formatter.rb and https://github.com/rubycoco/pakman/blob/master/lib/pakman/erb/templater.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants