Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing feed items author #29

Open
redtide opened this issue Apr 25, 2020 · 5 comments
Open

Missing feed items author #29

redtide opened this issue Apr 25, 2020 · 5 comments

Comments

@redtide
Copy link

redtide commented Apr 25, 2020

I see that at rubycocos/feedparser#3 this feature was implemented but when running pluto update planet.ini I get an empty author field in the database for each item.
I'm sure that most of the ATOM and RSS feeds contains the author name (which is visible in the current planet website). I'm using pluto 1.3.4 and feedparser 2.1.2.

@geraldb
Copy link
Member

geraldb commented Apr 25, 2020

Thanks for suggesting the missing author/authors field/fields. I try to update the database schema and feed item import with the next pluto update (that might take some weeks). You can find the current database schema @ https://github.com/feedreader/pluto/blob/master/pluto-models/lib/pluto/schema.rb#L143 PS: Do you have an example (multi-author) feed? What author info do you want to see added e.g. just some records of strings (author names) or more?

@redtide
Copy link
Author

redtide commented Apr 25, 2020

I need to display the post author name as set in the original RSS feed and/or ATOM, not what is set as title in planets.ini.
The example is http://planet.linuxaudio.org: at the end of each post the post's author is in a by <author> at <date> line.
My pluto version is at https://redtide.github.io/plutone/ where authors are replaced with the post title.

@geraldb
Copy link
Member

geraldb commented Apr 25, 2020

Thanks for sharing and highlighting the example. I see - makes definitely sense for multi-author feeds. I will add all the authors (as string columns) with the next update (alas, that might take some weeks). Thanks for the patience. Cheers. Prost.

@redtide
Copy link
Author

redtide commented Apr 25, 2020

Thanks, BTW, what do you mean with string columns? Shouldn't be just a single column in the items table?
planetdb

@geraldb
Copy link
Member

geraldb commented Apr 25, 2020

Sorry for the enterprise version - there can be many authors (in theory) - and, thus, the plan is to add a one-to-many author table with a string column. I will add a convenience author method that only gets you the first (or nothing) same as authors[0] - that matches / mirrors also the feedparser that matches / mirrors the rss/atom feed structure (as far as I can remember). Cheers. Prost. Note: It is not taking so long because of has_many but because I have to get some basics fixed that are broken for months in another project (that is, sportdb) and I'm not good at "multi-task" coding and "context-switching" (e.g. I can only do one thing for some days and than some others). Anyways, thanks for your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants