Wrong version of container starting from compose file #451

jshank · 2022-09-21T04:22:53Z

jshank
Sep 21, 2022

Bug description

When starting the container, I receive the following

[info] Starting felddy/foundryvtt container v10.284.0
[warn] FOUNDRY_VERSION has been manually set and does not match the container's version.
[warn] Expected 10.284 but found 10.285

I've upgraded to the latest container but somehow v10.284.0 has been "locked into the image". Looking through the Dockerfile, it declares ARG VERSION which is later sent to a text file. echo ${VERSION} > image_version.txt. This doesn't appear to get updated on subsequent updates to the image file.

Steps to reproduce

Download https://github.com/felddy/foundryvtt-docker/blob/develop/docker-compose.yml file
Modify the docker-compose.yml as follows:

    environment:
      - CONTAINER_PRESERVE_CONFIG=true
      - FOUNDRY_VERSION=10.285

Execute docker-compose up -d
Later upgrade to a newer version of the image

Expected behavior

Container version matches the release version of foundry

Container metadata

com.foundryvtt.version = "10.286"
org.opencontainers.image.authors = "markf+github@geekpad.com"
org.opencontainers.image.created = "2022-09-20T21:36:07.057Z"
org.opencontainers.image.description = "An easy-to-deploy Dockerized Foundry Virtual Tabletop server."
org.opencontainers.image.licenses = "MIT"
org.opencontainers.image.revision = "7144434df48d7551e8b64b0664ea597fb0b0d68f"
org.opencontainers.image.source = "https://github.com/felddy/foundryvtt-docker"
org.opencontainers.image.title = "foundryvtt-docker"
org.opencontainers.image.url = "https://github.com/felddy/foundryvtt-docker"
org.opencontainers.image.vendor = "Geekpad"
org.opencontainers.image.version = "10.286.0"

Relevant log output

foundryvtt | Entrypoint | 2022-09-20 20:59:37 | [info] Starting felddy/foundryvtt container v10.284.0
foundryvtt | Entrypoint | 2022-09-20 20:59:37 | [warn] FOUNDRY_VERSION has been manually set and does not match the container's version.
foundryvtt | Entrypoint | 2022-09-20 20:59:37 | [warn] Expected 10.284 but found 10.285
foundryvtt | Entrypoint | 2022-09-20 20:59:37 | [warn] The container may not function properly with this version mismatch.
foundryvtt | Entrypoint | 2022-09-20 20:59:38 | [info] Foundry Virtual Tabletop 10.285 is installed.
foundryvtt | Entrypoint | 2022-09-20 20:59:38 | [info] Not modifying existing installation license key.
foundryvtt | Entrypoint | 2022-09-20 20:59:38 | [info] Setting data directory permissions.

Code of Conduct

I agree to follow this project's Code of Conduct

Answered by jshank

Sep 22, 2022

Happy to share. Let me know if you see any red flags.

---
version: "3.8"

secrets:
  config_json:
    file: secrets.json

services:
  foundry:
    container_name: foundryvtt
    image: felddy/foundryvtt:release
    restart: unless-stopped
    hostname: shank_foundry_host
    init: true
    volumes:
      - type: bind
        source: ./data
        target: /data
      - type: bind
        source: ./foundry
        target: /home/foundry
      - type: bind
        source: '/mnt/media/seadrivecli/My Libraries/My Library/D&D'
        target: '/data/Data/D&D'
        read_only: true
      - type: bind
        source: '/mnt/media/music_organized'
        target: '/data/Data/music'
        read_only

View full answer

felddy · 2022-09-21T14:29:38Z

felddy
Sep 21, 2022
Maintainer

Thank you for the report.

This warning message you are seeing is working as expected. You have manually set the FOUNDRY_VERSION environment variable in your docker compose file. The version you set does not match the version that was used to create the container. The container will probably work as expected, but it was not tested in this configuration.

To correctly update your container remove the FOUNDRY_VERSION from your docker compose file, and pull a new image for the version. For example, if your compose file is using felddy/foundryvtt:release you can run docker compose pull and then docker compose up --detach

See:

0 replies

jshank · 2022-09-21T14:56:31Z

jshank
Sep 21, 2022
Author

I commented out the FOUNDRY_VERSION tag and pulled a new version. The issue persists:

foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [info] Starting felddy/foundryvtt container v10.284.0
foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [warn] FOUNDRY_VERSION has been manually set and does not match the container's version.
foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [warn] Expected 10.284 but found 10.286
foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [warn] The container may not function properly with this version mismatch.
foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [info] Reading configured secrets from: /run/secrets/config.json
foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [info] Foundry Virtual Tabletop 10.285 is installed.
foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [info] Requested version (10.286) from FOUNDRY_VERSION differs.
foundryvtt | Entrypoint | 2022-09-21 07:54:52 | [info] Uninstalling version 10.285.

0 replies

felddy · 2022-09-21T16:29:58Z

felddy
Sep 21, 2022
Maintainer

The current version of the container is 10.286.1. Your log is showing container version 10.284.0.

Verify that the tag you are using in your docker-compose.yml file is as expected. Usually this is :release.

Also check your logs to see if Docker is "recreating" the container. You'll want to re-up it so it is recreated with the image of the container you pulled, and the new environment with FOUNDRY_VERSION removed.

Here is the output I see after changing the image from felddy/foundryvtt:10.286.0 to felddy/foundryvtt:release:

❱ docker compose pull
foundry Pulling 
foundry Pulled 

❱ docker compose up --detach
Container foundryvtt-docker-foundry-1  Recreate
Container foundryvtt-docker-foundry-1  Recreated
Container foundryvtt-docker-foundry-1  Starting
Container foundryvtt-docker-foundry-1  Started

0 replies

jshank · 2022-09-21T18:20:04Z

jshank
Sep 21, 2022
Author

Confirmed docker-compose is using :release.
I've done docker-compose down (twice for good measure) then docker-compose up.
I've deleted the image completely and redownloaded.

What gets me is that :release is showing org.opencontainers.image.version = "10.286.1" but still shows Starting felddy/foundryvtt container v10.284.0

How does VERSION get populated in the first place?

0 replies

felddy · 2022-09-21T19:13:23Z

felddy
Sep 21, 2022
Maintainer

How does VERSION get populated in the first place?

VERSION is passed in at build time. If you were to build the container by hand you'd do it like this:

docker build \
  --build-arg VERSION=10.286.1 \
  --tag felddy/foundryvtt:10.286.1 \
  https://github.com/felddy/foundryvtt-docker.git#develop

In this repo, the builds are executed by GitHub Actions. The version of the image lives in _version.py and is read by the workflows:

foundryvtt-docker/src/_version.py

Line 3 in 9201293

__version__ = "10.286.1"

foundryvtt-docker/.github/workflows/_metadata.yml

Lines 49 to 52 in 9201293

    
                 - name: Calculate values from source 
        
                   id: source_values 
        
                   run: | 
        
                     echo ::set-output name=source_version::$(./bump_version.sh show)

foundryvtt-docker/.github/workflows/build.yml

Lines 139 to 148 in 9201293

    
             build-and-push: 
        
               needs: [config, docker-secrets, lint, metadata, test-normal-image, test-pre-installed-image] 
        
               if: github.event_name != 'pull_request' 
        
               name: "Publish" 
        
               permissions: 
        
                 packages: write 
        
               uses: ./.github/workflows/_build-push-all.yml 
        
               with: 
        
                 build_args: | 
        
                   VERSION=${{ needs.metadata.outputs.source_version }}

I'm know you said you did a down. Just making sure you weren't doing stop instead. They have different semantics.

What does your docker image list output look like?

❱ docker images felddy/foundryvtt
REPOSITORY          TAG        IMAGE ID       CREATED        SIZE
felddy/foundryvtt   10.286.1   3f929a6d0949   4 hours ago    221MB
felddy/foundryvtt   release    3f929a6d0949   4 hours ago    221MB
felddy/foundryvtt   10.286.0   166c6f356977   21 hours ago   221MB
felddy/foundryvtt   10.277.0   55dad723c92a   6 weeks ago    211MB
felddy/foundryvtt   10.276.0   2491574f1d76   7 weeks ago    211MB
felddy/foundryvtt   10.265.0   1844a4b8efbd   3 months ago   211MB

0 replies

jshank · 2022-09-21T21:13:03Z

jshank
Sep 21, 2022
Author

Thanks for sharing how that gets created.

docker images felddy/foundryvtt
REPOSITORY          TAG       IMAGE ID       CREATED        SIZE
felddy/foundryvtt   release   3f929a6d0949   5 hours ago    221MB
felddy/foundryvtt   <none>    166c6f356977   22 hours ago   221MB

0 replies

felddy · 2022-09-21T23:18:56Z

felddy
Sep 21, 2022
Maintainer

Hmmm. I have no idea! But I am ready for the exciting conclusion. Please don't give up on this.
I'm going to covert this into a discussion.

1 reply

felddy Sep 21, 2022
Maintainer

Would you be able to post your docker-compose.yml file?

jshank · 2022-09-22T03:28:25Z

jshank
Sep 22, 2022
Author

Happy to share. Let me know if you see any red flags.

---
version: "3.8"

secrets:
  config_json:
    file: secrets.json

services:
  foundry:
    container_name: foundryvtt
    image: felddy/foundryvtt:release
    restart: unless-stopped
    hostname: shank_foundry_host
    init: true
    volumes:
      - type: bind
        source: ./data
        target: /data
      - type: bind
        source: ./foundry
        target: /home/foundry
      - type: bind
        source: '/mnt/media/seadrivecli/My Libraries/My Library/D&D'
        target: '/data/Data/D&D'
        read_only: true
      - type: bind
        source: '/mnt/media/music_organized'
        target: '/data/Data/music'
        read_only: true
    environment:
      - CONTAINER_PRESERVE_CONFIG=true
      - CONTAINER_PRESERVE_OWNER=/data/Data/D&D\|/data/Data/music
      - TIMEZONE=America/Los_Angeles
      - FOUNDRY_UID=1000
      - FOUNDRY_VERSION=10.285
    ports:
      - target: 30000
        published: 30000
        protocol: tcp
    secrets:
      - source: config_json
        target: config.json
    labels:
      - "com.centurylinklabs.watchtower.enable=true"
      - "diun.enable=false"

1 reply

felddy Sep 22, 2022
Maintainer

Ah ha! This would be the cause:

      - type: bind
        source: ./foundry
        target: /home/foundry

The /home/foundry path is meant to be ephemeral. When you start a new version of the container, the updated home directory is getting clobbered by the previously saved one. Removing this volume will fix the issue you've reported.

See:

https://github.com/felddy/foundryvtt-docker#volumes

jshank · 2022-09-22T15:59:08Z

jshank
Sep 22, 2022
Author

Ah-ha! I'm running a slightly modified main.mjs which is why I've mapped out the /home/foundry directory. I now see the image_version.txt is also stored in there which is why it never gets upgraded. I've commented out the bind mount for testing but now am getting:

foundryvtt | ReleaseURL | 2022-09-22 08:57:31 | [info] Fetching S3 pre-signed release URL for build 285...
foundryvtt | file:///home/foundry/get_release_url.js:53
foundryvtt |         throw new Error(`Unexpected response ${response.statusText}`);
foundryvtt |               ^
foundryvtt | 
foundryvtt | Error: Unexpected response Too Many Requests
foundryvtt |     at fetchReleaseURL (file:///home/foundry/get_release_url.js:53:15)
foundryvtt |     at processTicksAndRejections (node:internal/process/task_queues:96:5)
foundryvtt |     at async main (file:///home/foundry/get_release_url.js:74:24)
foundryvtt |     at async file:///home/foundry/get_release_url.js:85:24

7 replies

jshank Sep 22, 2022
Author

Set CONTAINER_CACHE and it does seem to be working, thanks!

For CONTAINER_PATCHES, when you say sourced, can these just be shell scripts that are executed or do they have to be JS?

felddy Sep 22, 2022
Maintainer

They are expected to be shell scripts, but they can call other things if you need.

There are some examples in the patches directory of the repo:
https://github.com/felddy/foundryvtt-docker/tree/develop/patches

This is how they're called:

foundryvtt-docker/src/entrypoint.sh

Lines 195 to 200 in 16990ea

    
           for f in "${CONTAINER_PATCHES}"/*; do 
        
             [ -f "$f" ] || continue # we can't set nullglob in busybox 
        
             log "Sourcing patch from file: $f" 
        
             # shellcheck disable=SC1090 
        
             source "$f" 
        
           done

jshank Sep 23, 2022
Author

Alright, time to relearn sed.

Any idea why it tried to download the build when it already has it in the container_cache?

foundryvtt | Entrypoint | 2022-09-22 21:11:21 | [warn] Expected 10.286 but found 10.285
foundryvtt | Entrypoint | 2022-09-22 21:11:21 | [warn] The container may not function properly with this version mismatch.
foundryvtt | Entrypoint | 2022-09-22 21:11:21 | [info] Reading configured secrets from: /run/secrets/config.json
foundryvtt | Entrypoint | 2022-09-22 21:11:21 | [info] No Foundry Virtual Tabletop installation detected.
foundryvtt | Entrypoint | 2022-09-22 21:11:21 | [info] Using FOUNDRY_USERNAME and FOUNDRY_PASSWORD to authenticate.
foundryvtt | Authenticate | 2022-09-22 21:11:22 | [info] Requesting CSRF tokens from https://foundryvtt.com
foundryvtt | Authenticate | 2022-09-22 21:11:22 | [info] Logging in as: jshank
foundryvtt | Authenticate | 2022-09-22 21:11:23 | [info] Successfully logged in as: jshank
foundryvtt | Entrypoint | 2022-09-22 21:11:23 | [info] Using authenticated credentials to download release.
foundryvtt | ReleaseURL | 2022-09-22 21:11:23 | [info] Fetching S3 pre-signed release URL for build 285...
foundryvtt | file:///home/foundry/get_release_url.js:53
foundryvtt |         throw new Error(`Unexpected response ${response.statusText}`);
foundryvtt |               ^
foundryvtt | 
foundryvtt | Error: Unexpected response Too Many Requests
foundryvtt |     at fetchReleaseURL (file:///home/foundry/get_release_url.js:53:15)
foundryvtt |     at processTicksAndRejections (node:internal/process/task_queues:96:5)
foundryvtt |     at async main (file:///home/foundry/get_release_url.js:74:24)
foundryvtt |     at async file:///home/foundry/get_release_url.js:85:24
jshank@shanknas:/mnt/media/docker-configs/foundryvtt$ ls ./data/container_cache/
foundryvtt-10.284.zip  foundryvtt-10.285.zip  foundryvtt-10.286.zip

jshank Sep 23, 2022
Author

Interestingly, when the S3 congestion clears, it starts working

foundryvtt | Entrypoint | 2022-09-22 21:18:39 | [info] Using authenticated credentials to download release.
foundryvtt | ReleaseURL | 2022-09-22 21:18:39 | [info] Fetching S3 pre-signed release URL for build 285...
foundryvtt | Entrypoint | 2022-09-22 21:18:39 | [info] Using CONTAINER_CACHE: /data/container_cache
foundryvtt | Entrypoint | 2022-09-22 21:18:39 | [info] Downloading Foundry Virtual Tabletop release.
foundryvtt |   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
foundryvtt |                                  Dload  Upload   Total   Spent    Left  Speed
foundryvtt | 
foundryvtt |   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
foundryvtt |   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
foundryvtt | Entrypoint | 2022-09-22 21:18:40 | [info] Installing Foundry Virtual Tabletop 10.285
foundryvtt | Entrypoint | 2022-09-22 21:18:43 | [info] Preserving release archive file in cache.
foundryvtt | Entrypoint | 2022-09-22 21:18:43 | [info] Using CONTAINER_PATCHES: /data/container_patches
foundryvtt | Entrypoint | 2022-09-22 21:18:43 | [warn] Container patches directory not found.
foundryvtt | Entrypoint | 2022-09-22 21:18:43 | [info] Not modifying existing installation license key.
foundryvtt | Entrypoint | 2022-09-22 21:18:43 | [info] Setting data directory permissions.
foundryvtt | Entrypoint | 2022-09-22 21:18:43 | [info] Starting launcher with uid:gid as 1000:foundry.

felddy Sep 23, 2022
Maintainer

Yes. This is expected. It is comparing the modification date of the file in the cache to the file in the S3 bucket. It is not unheard of for the Foundry team to do. a re-release without bumping the version number. Though, they have been better about this lately.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrong version of container starting from compose file #451

{{title}}

Replies: 9 comments 9 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Wrong version of container starting from compose file #451

jshank Sep 21, 2022

Bug description

Steps to reproduce

Expected behavior

Container metadata

Relevant log output

Code of Conduct

Replies: 9 comments · 9 replies

felddy Sep 21, 2022 Maintainer

jshank Sep 21, 2022 Author

felddy Sep 21, 2022 Maintainer

jshank Sep 21, 2022 Author

felddy Sep 21, 2022 Maintainer

jshank Sep 21, 2022 Author

felddy Sep 21, 2022 Maintainer

felddy Sep 21, 2022 Maintainer

jshank Sep 22, 2022 Author

felddy Sep 22, 2022 Maintainer

jshank Sep 22, 2022 Author

jshank Sep 22, 2022 Author

felddy Sep 22, 2022 Maintainer

jshank Sep 23, 2022 Author

jshank Sep 23, 2022 Author

felddy Sep 23, 2022 Maintainer

jshank
Sep 21, 2022

Replies: 9 comments 9 replies

felddy
Sep 21, 2022
Maintainer

jshank
Sep 21, 2022
Author

felddy
Sep 21, 2022
Maintainer

jshank
Sep 21, 2022
Author

felddy
Sep 21, 2022
Maintainer

jshank
Sep 21, 2022
Author

felddy
Sep 21, 2022
Maintainer

felddy Sep 21, 2022
Maintainer

jshank
Sep 22, 2022
Author

felddy Sep 22, 2022
Maintainer

jshank
Sep 22, 2022
Author

jshank Sep 22, 2022
Author

felddy Sep 22, 2022
Maintainer

jshank Sep 23, 2022
Author

jshank Sep 23, 2022
Author

felddy Sep 23, 2022
Maintainer