Fullscreen button fixed.

felicien-brochu · Nov 8, 2016 · b3bb29f · b3bb29f
1 parent fcaefd0
commit b3bb29f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/src/css/style.css b/src/css/style.css
@@ -74,6 +74,9 @@
 .gog-ic-pause {
 	display: none;
 }
+.gog-ic-fullscreen-exit {
+	display: none;
+}
 #gog-bottom-action-buttons {
 	position: absolute;
 	right: 0;
@@ -91,8 +94,8 @@
 	width: 46px;
 }
 #gog-fullscreen-button svg {
-	width: 30;
-	height: 30;
+	width: 30px;
+	height: 30px;
 }
 #gog-bottom-action-buttons .gog-action-button.gog-small {
 	width: 34px;

diff --git a/src/index.html b/src/index.html
@@ -78,7 +78,8 @@
 			<svg><use xlink:href="svg/sprite.svg#shape-ic-tutorial"></use></svg>
 		</button></li>
 		<li><button id="gog-fullscreen-button" class="gog-action-button">
-			<svg><use xlink:href="svg/sprite.svg#shape-ic-fullscreen"></use></svg>
+			<svg class="gog-ic-fullscreen"><use xlink:href="svg/sprite.svg#shape-ic-fullscreen"></use></svg>
+			<svg class="gog-ic-fullscreen-exit"><use xlink:href="svg/sprite.svg#shape-ic-fullscreen-exit"></use></svg>
 		</button></li>
 	</ul>
 

diff --git a/src/js/settings.js b/src/js/settings.js
@@ -183,10 +183,15 @@ Settings.prototype.onFullscreenButtonMouseDown = function() {
 }
 
 Settings.prototype.onFullscreenChange = function() {
+	var fullscreenIcon = this.fullscreenButton.getElementsByClassName("gog-ic-fullscreen")[0];
+	var fullscreenExitIcon = this.fullscreenButton.getElementsByClassName("gog-ic-fullscreen-exit")[0];
+
 	if (getFullscreenElement()) {
-		this.fullscreenButton.childNodes[0].childNodes[0].setAttribute("xlink:href", "svg/sprite.svg#shape-ic-fullscreen-exit");
+		fullscreenIcon.style.display = "none";
+		fullscreenExitIcon.style.display = "inline-block";
 	} else {
-		this.fullscreenButton.childNodes[0].childNodes[0].setAttribute("xlink:href", "svg/sprite.svg#shape-ic-fullscreen");	
+		fullscreenIcon.style.display = "inline-block";
+		fullscreenExitIcon.style.display = "none";
 	}
 }