Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify griffe as an extra rather than a dependency group #40

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

harrymander
Copy link
Contributor

Properly specifies griffe as an extra rather than a dependency group.

Dependency groups as used here specific to Poetry and are used for development, building docs etc. Extras add additional functionality that can be installed via pip: https://python-poetry.org/docs/managing-dependencies/.

This fixes pip error when installing with pydanclick[griffe]:

WARNING: pydanclick 0.3.0 does not provide the extra 'griffe'

Copy link
Owner

@felix-martel felix-martel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@felix-martel felix-martel merged commit c6e773d into felix-martel:main Nov 13, 2024
6 checks passed
@harrymander harrymander deleted the griffe-extra branch November 19, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants