Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addpkg: lftp #3264

Merged
merged 1 commit into from
Nov 19, 2023
Merged

addpkg: lftp #3264

merged 1 commit into from
Nov 19, 2023

Conversation

Nightwulf
Copy link
Contributor

Original author contacted to update config.guess/config.sub. Added those two files and modified PKGBUILD zo perform autoupdate/autoreconf until that is done.

@r-value
Copy link
Collaborator

r-value commented Nov 16, 2023

  • please submit a patch instead of a full PKGBUILD file
  • usually a line of autoreconf -fiv can solve the problem instead of manually overwrite them
  • you can leave a link to your contact threads if possible

@r-value
Copy link
Collaborator

r-value commented Nov 16, 2023

#3199 could be a good example for you

@Nightwulf
Copy link
Contributor Author

original author contacted about the issue: lavv17/lftp#717

Xeonacid
Xeonacid reviewed Nov 17, 2023
View reviewed changes
lftp/riscv64.patch Outdated
diff --git a/PKGBUILD b/PKGBUILD
index df5e9c3..9ed745c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the a/ b/ as other patches do.

r-value
r-value approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@r-value r-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

r-value
r-value reviewed Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@r-value r-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be better if you can tidy your commit history and squash the commits into a single one :)

@Nightwulf
Copy link
Contributor Author

done

@felixonmars
Copy link
Owner

Thanks!

@felixonmars felixonmars merged commit 020afeb into felixonmars:master Nov 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-value r-value r-value approved these changes

@Xeonacid Xeonacid Xeonacid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nightwulf @r-value @felixonmars @Xeonacid