Updating dwarfs targets and rosters #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to start the process of updating the default photometric properties for the dwarfs to reflect the newest measurements collected in the 2020 dwarf census (1912.03302). The big question for this PR is how we want to deal with changing the default values. Due to the library structure, a change to the ra,dec in the defaults will propagate to each of the other rosters that depends on the defaults to set these values. This will cause an unexpected change for users who will now see slight shifts in their satellite parameters without having updated anything.
There are two possible ways to address this (though neither has been done yet):
base: default2020
(the default isbase: default
). This will leave the default unchanged for the older targets.defaults2016
and have every old target explicitly derive frombase: default2016
.It seems like we should probably start specifying the
base
explicitly in all new and old targets. Maybe this is a good time to make this change.