You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
It seems that when computing the lightcurve, the "norm" and "shape" of the source of interest will always be free (for niter == 0) if the source has a ts > shape_ts_threshold even if the option free_params is specified, for example, with only one parameter of the shape.
Expected behavior
I would expect inside the conditional something like:
if niter == 0:
gta.free_sources_by_name(free_sources_norm, pars='norm')
gta.free_sources_by_name(free_sources_shape, pars='shape')
if free_params:
gta.free_source(name, False)
gta.free_source(name, True, pars='norm')
gta.free_source(name, True, pars=free_params)
Also, I would add in the description of the option free_paramssomething like "if the TS of the source is above shape_ts_threshold"
Additional context
The option free_params in lightcurve is meant to set the parameters of the source of interest that will be re-fit in each time bin. If this list is empty then all parameters will be freed.
The text was updated successfully, but these errors were encountered:
Describe the bug
It seems that when computing the lightcurve, the "norm" and "shape" of the source of interest will always be free (for niter == 0) if the source has a
ts > shape_ts_threshold
even if the option free_params is specified, for example, with only one parameter of the shape.Expected behavior
I would expect inside the conditional something like:
Also, I would add in the description of the option
free_params
something like "if the TS of the source is aboveshape_ts_threshold
"Additional context
The option free_params in lightcurve is meant to set the parameters of the source of interest that will be re-fit in each time bin. If this list is empty then all parameters will be freed.
The text was updated successfully, but these errors were encountered: