Add .NET Aspire Dashboard as alternative observability stack #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
calebschoepp
requested changes
Oct 10, 2024
cmd/setup.go
Outdated
| if err := checkDocker(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| composeFile := path.Join(otelConfigPath, "compose.yaml") | ||
| fn := s.GetComposeFileName() |
There was a problem hiding this comment.
The name fn here makes me think you're holding a function in this variable.
There was a problem hiding this comment.
Renamed in 4dea516
cmd/stack.go
Outdated
| @@ -0,0 +1,30 @@ | |||
| package cmd | |||
There was a problem hiding this comment.
I feel like this might belong in a stack package under /internal/stack/stack.go or something like that.
There was a problem hiding this comment.
I moved Stack to internal/stack in 70cee1a
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds .NET Aspire Dashboard (Standalone Mode) as alternative observability stack.
Users can specify the
--aspireflag as part ofspin otel setup:Additionally, a new sub-command is added to
spin otel opento open the Aspire Dashboard UI from the terminal:Fixes #19