Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating help messages and removing windows + arm64 from release #6

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
- { goArch: "amd64", goOs: "linux", pluginifyArch: "amd64", pluginifyOs: linux}
- { goArch: "arm64", goOs: "linux", pluginifyArch: "aarch64", pluginifyOs: linux}
- { goArch: "amd64", goOs: "windows", pluginifyArch: "amd64", pluginifyOs: windows}
- { goArch: "arm64", goOs: "windows", pluginifyArch: "aarch64", pluginifyOs: windows}
- { goArch: "arm64", goOs: "darwin", pluginifyArch: "amd64", pluginifyOs: macos}
- { goArch: "amd64", goOs: "darwin", pluginifyArch: "aarch64", pluginifyOs: macos}
steps:
Expand Down
2 changes: 1 addition & 1 deletion cmd/open.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ import (

var openCmd = &cobra.Command{
Use: "open",
Short: "Opens the desired OTel UI in the default browser. Accepts the following arguments: 'prometheus' or 'p', 'grafana' or 'g', 'jaeger' or 'j'.",
Short: "Opens the desired OTel UI in the default browser.",
}
3 changes: 2 additions & 1 deletion cmd/up.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import (

var upCmd = &cobra.Command{
Use: "up",
Short: "Runs a Spin App with the default OTel environment variables. Flags for the 'spin up' command can be used as well: 'spin otel up -- --help'",
Short: "Runs a Spin App with the default OTel environment variables.",
Long: "Runs a Spin App with the default OTel environment variables. Any flags that work with the `spin up` command, will work with the `spin otel up` command: 'spin otel up -- --help'",
RunE: func(cmd *cobra.Command, args []string) error {
if err := up(args); err != nil {
return err
Expand Down
Loading