Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some small improvements #7

Merged
merged 1 commit into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
otel-plugin
otel
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Spin OTel Plugin

This is a plugin that makes it easy to use OTel with Spin.
This is a plugin that makes it easy to use OTel with Spin.

## Background

Expand Down Expand Up @@ -33,7 +33,7 @@ Alternatively, use the `spin pluginify` plugin to install from a fresh build. Th

```sh
spin plugins install pluginify
cargo build --release
go build -o otel
spin pluginify install
```

Expand Down Expand Up @@ -67,7 +67,7 @@ Dashboard for viewing metrics and logs:
spin otel open grafana
```

Dashboard for viewing trace data:
Dashboard for viewing trace data:

```sh
spin otel open jaeger
Expand All @@ -83,4 +83,4 @@ spin otel open prometheus

```sh
spin otel cleanup
```
```
File renamed without changes.
File renamed without changes.
File renamed without changes.
8 changes: 4 additions & 4 deletions cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"fmt"
"os"

openSubCmds "github.com/fermyon/otel-plugin/cmd/open-subcmd"
open "github.com/fermyon/otel-plugin/cmd/open"
"github.com/spf13/cobra"
)

Expand All @@ -28,7 +28,7 @@ func init() {
rootCmd.AddCommand(cleanUpCmd)
rootCmd.AddCommand(setUpCmd)
rootCmd.AddCommand(openCmd)
openCmd.AddCommand(openSubCmds.GrafanaCmd)
openCmd.AddCommand(openSubCmds.JaegerCmd)
openCmd.AddCommand(openSubCmds.PrometheusCmd)
openCmd.AddCommand(open.GrafanaCmd)
openCmd.AddCommand(open.JaegerCmd)
openCmd.AddCommand(open.PrometheusCmd)
}
Loading