Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coins parsing fix to support ibc denoms #377

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

MissingNO57
Copy link
Contributor

@MissingNO57 MissingNO57 commented Oct 27, 2023

Proposed changes

Original PR by george-aj #375

The current parse_coins regex is not able to handle ibc denoms. For any network that supports paying fees in the non native token this results in the denom being just ibc

The proposed change modifies the regex slightly to account for ibc denoms.

Issues

Links to any issues resolved.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected)
  • Something else (e.g. tests, scripts, example, deployment, infrastructure, ...)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document.
  • I have based my branch, and I am making a pull request against, the main branch.
  • Checks and tests pass locally.

If applicable

  • I have added tests that prove my fix is effective or that my feature works.
  • I have checked that code coverage does not decrease.
  • I have added/updated the documentations.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

@MissingNO57 MissingNO57 merged commit 726d56f into main Oct 27, 2023
32 checks passed
@MissingNO57 MissingNO57 deleted the feature/ibc_coins_parsing branch October 27, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants