Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix bug in tooltip hover #943

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshua-demo
Copy link

Proposed Changes

[Able to hover over tool tip message and click on Agentverse link]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Content update.
  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

@joshua-demo joshua-demo changed the title fix: fix bug in tooltip hover fix(docs): fix bug in tooltip hover Sep 11, 2024
@devjsc
Copy link
Member

devjsc commented Sep 11, 2024

hey @joshua-demo nice catch, you're right the hover effect isn't very good. I think for best UX we should have it click on, click anywhere off. Would you like to update for this functionality, else we'll fix this 👍

@joshua-demo
Copy link
Author

hi @devjsc I found it more common when there is an information svg, for it to be a tooltip where it will automatically hide the modal after a small amount of time when hovering off the tootip modal or the information svg. If you still think the button version is better, I can also update for that functionality.

@devjsc
Copy link
Member

devjsc commented Sep 12, 2024

Interesting, i thought best UX for modals is click anywhere for off, expected behaviour (imo):

  • click on tooltip icon, popup displays
  • scroll, click on tooltip icon, or click anywhere else on screen popup closes.

What do you think @gautamgambhir97 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants