Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): USGS Earthquake Details Integration #533

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

steeevin88
Copy link

Proposed Changes

Adds an integration that provides USGS earthquake details when provided an earthquake ID.

Linked Issues

Not applicable

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

@devjsc devjsc added the a-integrations Area: Integrations - changes to integrations but not the core framework label Sep 18, 2024
@devjsc
Copy link
Member

devjsc commented Sep 18, 2024

Hello @steeevin88 cool project! Could you update the integration to be under community/ section of integrations, not at root level? thanks!

@steeevin88
Copy link
Author

Hello @steeevin88 cool project! Could you update the integration to be under community/ section of integrations, not at root level? thanks!

Hey @devjsc, I don't see a community/ section in integrations, did you mean for me to add a new section (/integrations/community/usgs_eq_details)?

@devjsc
Copy link
Member

devjsc commented Sep 18, 2024

Sorry @steeevin88 I got aheady of myself, in PR #534 i introduce the community/ dir if you create that dir in your branch I will merge when #534 lands 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-integrations Area: Integrations - changes to integrations but not the core framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants