Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): agent shutdown routine #578

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

Archento
Copy link
Member

Proposed Changes

This PR:

  • fix the shutdown routine when using the mailbox
  • add graceful shutdown for remaining tasks
  • fixes KeyboardInterrupt again
  • refactor registration loop

Linked Issues

closes: #577

Types of changes

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Archento Archento merged commit 39947f7 into main Nov 18, 2024
9 checks passed
@Archento Archento deleted the fix/agent-shutdown-routine branch November 18, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent shutdown event is not triggered
2 participants