rm sportradar id from rankings (#72)

ffverse · Oct 3, 2024 · 9d8bc79 · 9d8bc79
1 parent 838897a
commit 9d8bc79
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: ffsimulator
 Title: Simulate Fantasy Football Seasons
-Version: 1.2.3.01
+Version: 1.2.3.02
 Authors@R: 
     person(given = "Tan",
            family = "Ho",

diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,7 @@
 - Update available fantasypros rankings to include 2022
 - Require ggplot2 3.4.0 for plotting features
 - Draws from a slightly broader sample of players for season outcomes
+- Fix weekly sims - fantasypros no longer returns sportradar ids (fixes #71)
 
 
 ---

diff --git a/R/2_rankings.R b/R/2_rankings.R
@@ -35,12 +35,12 @@ ffs_latest_rankings <- function(type = c("draft","week")) {
         "bye",
         "ecr",
         "sd",
-        "sportradar_id" = "sportsdata_id",
+        # "sportradar_id" = "sportsdata_id",
         "scrape_date")]
 
     names(fp_cleaned)[2] <- "fantasypros_id"
     names(fp_cleaned)[4] <- "team"
-    names(fp_cleaned)[8] <- "sportradar_id"
+    # names(fp_cleaned)[8] <- "sportradar_id"
 
     if(all(is.na(fp_cleaned$bye))) fp_cleaned$bye <- 0
 
@@ -56,7 +56,7 @@ ffs_latest_rankings <- function(type = c("draft","week")) {
                                "team",
                                "ecr",
                                "sd",
-                               "sportradar_id",
+                               #"sportradar_id",
                                "scrape_date")]
     names(fp_cleaned)[1] <- "player"