Centralize viewArea state in Visualization #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable zooming/viewport scaling - Scale visualization to full window size - Make tooltips scrollable when they are larger than the screen size
- Allows for modifying the content before the tooltip is shown, which previously broke the tooltip positioning
- Much simpler event flow - Major performance improvements when scrolling locally in large visualizations - Many bug fixes. The major ones are: - Scrolling & event bundling works again - Touch drag works again - Decoupled throttle intervals (passing this.draw as object to call_throttled calls draw on only one object and swallows calls from other objects)
boeddeker
reviewed
Mar 28, 2024
boeddeker
reviewed
Mar 28, 2024
meeteval/viz/visualize.js
Outdated
| for (let j = anchor + 1; j < viewAreas.length; j++) { | ||
| let v = viewAreas[j]; | ||
| const parent = viewAreas[j - 1]; | ||
| if (parent[1] - parent[0] < v[1] - v[0] || similar_range(oldViewAreas[j - 1], v)) { |
There was a problem hiding this comment.
Should it be marked as dirty, when the values ares the same? A draw wouldn't be necessary.
There was a problem hiding this comment.
Solved, now only marked as dirty when !similar_rate(viewAreas[j], v)
boeddeker
reviewed
Mar 28, 2024
| function adjustViewAreas(viewAreas, anchor, viewArea) { | ||
| const dirty = viewAreas.map(() => false); | ||
|
|
||
| const oldViewAreas = [...viewAreas]; |
There was a problem hiding this comment.
I am not sure, if it works as intended. You do inplace changes and keep only the old value if the child is larger than the parent.
If this is the indented behavior, it should be documented.
boeddeker
reviewed
Mar 28, 2024
boeddeker
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The viewAreas are now managed in a central location instead of in the local minimap objects. The central state is a single source of truth and eliminates much of the communication between plot objects. This has a few benefits:
Additionally, functionality was added to synchronize plots in a side-by-side view.