Add greedy time-constrained ORC-WER #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add again a print in the cli. e.g. printing the files that are written and/or a summary of the WER. |
boeddeker
reviewed
Sep 17, 2024
boeddeker
reviewed
Sep 17, 2024
boeddeker
reviewed
Sep 17, 2024
| tmp[current, 0] = tmp[prev, 0] + 1 | ||
| for i in range(1, a.shape[0] + 1): | ||
| a_ = a[i - 1] | ||
| if a_begin[i - 1] >= b_end_ or b_begin_ >= a_end[i - 1]: |
There was a problem hiding this comment.
Do we use touching as no overlap?
There was a problem hiding this comment.
Yes, we decided for this in the time-constrained Levenshtein distance inn levenshtein.h and now everything is tested against that. I think the argument was that two time points should not overlap
There was a problem hiding this comment.
ok. I just wanted to ensure, that it is the same.
Yes, I agree. But that should be a separate PR. |
boeddeker
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.