add more normalizers, "lower,rm([^a-z0-9 ])" and chime6/7/8 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thequilo
approved these changes
Sep 18, 2024
| f'You discovered an idempotence bug in the chime_utils normalizer: {normalizer!r}.\n' | ||
| f'Original: {seg["words"]}\n' | ||
| f'Normalized: {words}\n' | ||
| f'Normalized again: {chime_utils_normalizer(words)}' |
There was a problem hiding this comment.
Add instructions for what the user should do if this happens?
There was a problem hiding this comment.
After an offline discussion, we decided to not include a link to the github chime_utils or meeteval issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the if statement in the source code to a class to have all code together that belongs to the normalizer.
The chimeX normalizers have a runtime dependency of chime-utils