Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouselook causing softlock in The Duel #532

Open
wants to merge 1 commit into
base: port
Choose a base branch
from

Conversation

ZenithMDC
Copy link

Moving the mouse could cause Joanna's starting angle to be incorrect, leading to a soft lock in The Duel. I tried to solve this issue using my inputResetRelativeMouseState function from my prior PR #530, but to no avail. So, I spun this off into its own PR. My current solution is to force movedata.freelookdx and movedata.freelookdy to be zero, any time playerReset is called. It gets the job done, but it's kind of hacky. Any suggestions would be appreciated.

@fgsfdsfgs
Copy link
Owner

Can you explain exactly how to get the softlock? Camera seems to be correctly locked forward until you stop walking for me.

@ZenithMDC
Copy link
Author

ZenithMDC commented Nov 16, 2024

Okay. This is going to sound crazy, but getting this bug to exhibit itself while running OBS is like 1 in 1000000. I thought, okay, maybe hooking into the game with Game Capture and/or Audio Capture is altering the outcome, so I tried just Display Capture, but I still couldn't get it easily recorded that way. When I'm not screen capturing, I can get it to happen in about 5-10 iterations of Replay Last Level. Unfortunately, I don't understand how exactly to reproduce the bug. All I know is that it occurs when using the mouse to navigate the menus prior to selecting this mission / replaying it. When I used the keyboard to navigate the menus, it never occurred.

I logged the mouse output and It's caused by movedata.freelookdx and movedata.freelookdy having non-zero values as the mission loads.

I managed to get a recording of it only once, and it was during the much less likely scenario where it occurs when selecting the mission from the main menu. Ignore the gibberish at the bottom of the screen and other rendering oddities. That's from OBS and/or FFmpeg.

duel_bug.mp4

Oh, and this is with d747588, btw. x86_64 build, though this is actually an old bug and happens with either architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants