Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectSelector rewrite #4

Open
stubb opened this issue Mar 14, 2016 · 3 comments
Open

ObjectSelector rewrite #4

stubb opened this issue Mar 14, 2016 · 3 comments

Comments

@stubb
Copy link
Member

stubb commented Mar 14, 2016

From @prock-fife on April 6, 2012 15:31

This issue was reported by chewie

This plugin needs a refactoring; it is slow implementation-wise and should be more flexible.

Other issues which should be taken into consideration:

  • vertical / horizontal modes to e.g. make it possible to use the bottom / top dockareas as well (not possible right now as you won't see most of the plugins gui)
  • scroll position when you select an object namespace should be removed as it is annoying instead of helpful
  • preview should be only enabled in text-mode (no need to display the same image twice)
  • image-mode should highlight the current active selection

Copied from original issue: fifengine/fifengine#686

@stubb
Copy link
Member Author

stubb commented Mar 14, 2016

From @prock-fife on April 10, 2012 5:50

This comment was posted by chewie

(In [3909]) - refactored ObjectSelector
- added auto-alignment depending on docking area (vertical/horizontal)
- right click can be used to trigger the alignment change manually
- no annoying resizes on object selection
- speed issues not fully solved, but pin-pointed: resizing ~200 icons is a bit too much for pychan

  • gui Plugins can now use auto-alignment functionality from the ToolBar class
  • small design fix in LayerTool
  • small fix for MapFileHistory
  • editor now doesn't load the same mapfile twice (gives feedback in the statusbar)

related to refs #686

@stubb
Copy link
Member Author

stubb commented Mar 14, 2016

From @prock-fife on April 10, 2012 21:12

This comment was posted by chewie

(In [3910]) - re-enabled saving for ObjectEdit plugin

  • implemented XMLObjectSaver which allows serialization of a fife.Object
    • NOTE: only well-formed xml files are accepted
    • NOTE: provides a compat-mode to scan for tree roots, but also uses new tree root
    • added namespace sorting to ObjectSelector
    • related to refs #686

@stubb
Copy link
Member Author

stubb commented Mar 14, 2016

From @prock-fife on April 16, 2012 0:18

This comment was posted by chewie

(In [3917]) - refactored ObjectEdit
- removed AnimationViewer component
- added new cell cost & cost id property (not loaded by trunk/ loaders)
- added cellstackposition property (not loaded by trunk/ loaders)
- plugin now also saves it's docking status in the editor settings file
- objects selected in the ObjectSelector now also update the ObjectEdit plugin
- removed all instance related options
- the plugin does however use the selected instance (if present) to show e.g. selected actions or rotations (not working for animated instances yet, as those need a facing location and don't react on instance.setRotation())
- image offset of animated objects can now be editted - the plugin applies the new offset to all animation frames
- saving animation image offsets does not work however (we need to migrate to new XML structure first)

  • small fix for InstanceHighlighter (deselects previous highlighted instances on new selections)
  • small fix for ObjectSelector - moved signal for onObjectSelector elsewhere (!= to Elsweyr ;-))
  • adjusted XMLObjectSaver to also save new object properties

related to , refs #686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant