chore: remove token where possible (#289)

We only need this to download a single release from github. We don't need to stick this in every command's environment.
filecoin-project · Apr 29, 2022 · 7bb44b8 · 7bb44b8
1 parent a55848d
commit 7bb44b8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/.github/actions/rust-cargo-run/action.yml b/.github/actions/rust-cargo-run/action.yml
@@ -11,6 +11,9 @@ inputs:
   components:
     description: The components to include when installing Rust
     required: false
+  github_token:
+    description: Github Token
+    required: true
   save_cache:
     description: Whether to save the SSCACHE
     required: false
@@ -28,6 +31,7 @@ runs:
   - name: Setting up cache
     uses: pl-strflt/rust-sccache-action@v1
     env:
+      GITHUB_TOKEN: ${{ inputs.github_token }}
       SCCACHE_CACHE_SIZE: 2G
       SCCACHE_DIR: ${{ github.workspace }}/.cache/sccache
       CACHE_SKIP_SAVE: ${{ inputs.save_cache == '' || inputs.save_cache == 'false' }}

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,12 +14,11 @@ jobs:
       uses: actions/checkout@v2
     - name: Running rustfmt
       uses: ./.github/actions/rust-cargo-run
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         command: fmt
         args: -- --check
         components: rustfmt
+        github_token: ${{ secrets.GITHUB_TOKEN }}
 
   check-clippy:
     runs-on: ubuntu-latest
@@ -28,12 +27,11 @@ jobs:
       uses: actions/checkout@v2
     - name: Running clippy
       uses: ./.github/actions/rust-cargo-run
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         command: clippy
         args: --all
         components: clippy
+        github_token: ${{ secrets.GITHUB_TOKEN }}
 
   test:
     runs-on: ubuntu-latest
@@ -42,16 +40,14 @@ jobs:
       uses: actions/checkout@v2
     - name: Running tests
       uses: ./.github/actions/rust-cargo-run
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         command: test
         args: --all
+        github_token: ${{ secrets.GITHUB_TOKEN }}
 
   build:
     runs-on: ubuntu-latest
     env:
-      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       CARGO_INCREMENTAL: 0
       CACHE_SKIP_SAVE: ${{ matrix.push == '' || matrix.push == 'false' }}
     strategy:
@@ -62,10 +58,9 @@ jobs:
       uses: actions/checkout@v2
     - name: Install Rust toolchain
       uses: ./.github/actions/rust-cargo-run
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       with:
         command: version
+        github_token: ${{ secrets.GITHUB_TOKEN }}
     - name: Writing bundle
       env:
         BUILD_FIL_NETWORK: ${{ matrix.network }}