Skip to content

Commit

Permalink
EVM: more unit tests (#1163)
Browse files Browse the repository at this point in the history 
* test sload

* test sstore

* make lint happy in macro expansion

* test log0

* test log1

* test log2,3,4
  • Loading branch information
@vyzo
vyzo authored Feb 6, 2023
1 parent ac26494 commit c5cbd5b
Show file tree
Hide file tree
Showing 3 changed files with 300 additions and 0 deletions.
244 changes: 244 additions & 0 deletions actors/evm/src/interpreter/instructions/log_event.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,247 @@ pub fn log(

Ok(())
}

#[cfg(test)]
mod tests {
use fil_actors_evm_shared::uints::U256;
use fvm_ipld_encoding::{to_vec, BytesSer, RawBytes};
use fvm_shared::event::{ActorEvent, Entry, Flags};

use super::{EVENT_DATA_KEY, EVENT_TOPIC_KEYS};
use crate::evm_unit_test;

#[test]
fn test_log0() {
evm_unit_test! {
(rt) {
let mut data = [0u8; 32];
data[28] = 0xCA;
data[29] = 0xFE;
data[30] = 0xBA;
data[31] = 0xBE;
rt.expect_emitted_event(
ActorEvent::from(vec![Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_DATA_KEY.to_owned(),
value: RawBytes::serialize(BytesSer(&data)).unwrap(),
}])
);
}
(m) {
PUSH4; 0xCA; 0xFE; 0xBA; 0xBE;
PUSH0;
MSTORE;
PUSH1; 0x20;
PUSH0;
LOG0;
}

let result = m.execute();
assert!(result.is_ok(), "execution step failed");
};
}

#[test]
fn test_log1() {
evm_unit_test! {
(rt) {
let t1 = U256::from(0x01);
let mut data = [0u8; 32];
data[28] = 0xCA;
data[29] = 0xFE;
data[30] = 0xBA;
data[31] = 0xBE;
rt.expect_emitted_event(
ActorEvent::from(vec![
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[0].to_owned(),
value: to_vec(&t1).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_DATA_KEY.to_owned(),
value: RawBytes::serialize(BytesSer(&data)).unwrap(),
}
])
);
}
(m) {
PUSH4; 0xCA; 0xFE; 0xBA; 0xBE;
PUSH0;
MSTORE;
PUSH1; 0x01;
PUSH1; 0x20;
PUSH0;
LOG1;
}

let result = m.execute();
assert!(result.is_ok(), "execution step failed");
};
}

#[test]
fn test_log2() {
evm_unit_test! {
(rt) {
let t1 = U256::from(0x01);
let t2 = U256::from(0x02);
let mut data = [0u8; 32];
data[28] = 0xCA;
data[29] = 0xFE;
data[30] = 0xBA;
data[31] = 0xBE;
rt.expect_emitted_event(
ActorEvent::from(vec![
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[0].to_owned(),
value: to_vec(&t1).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[1].to_owned(),
value: to_vec(&t2).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_DATA_KEY.to_owned(),
value: RawBytes::serialize(BytesSer(&data)).unwrap(),
}
])
);
}
(m) {
PUSH4; 0xCA; 0xFE; 0xBA; 0xBE;
PUSH0;
MSTORE;
PUSH1; 0x02;
PUSH1; 0x01;
PUSH1; 0x20;
PUSH0;
LOG2;
}

let result = m.execute();
assert!(result.is_ok(), "execution step failed");
};
}

#[test]
fn test_log3() {
evm_unit_test! {
(rt) {
let t1 = U256::from(0x01);
let t2 = U256::from(0x02);
let t3 = U256::from(0x03);
let mut data = [0u8; 32];
data[28] = 0xCA;
data[29] = 0xFE;
data[30] = 0xBA;
data[31] = 0xBE;
rt.expect_emitted_event(
ActorEvent::from(vec![
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[0].to_owned(),
value: to_vec(&t1).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[1].to_owned(),
value: to_vec(&t2).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[2].to_owned(),
value: to_vec(&t3).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_DATA_KEY.to_owned(),
value: RawBytes::serialize(BytesSer(&data)).unwrap(),
}
])
);
}
(m) {
PUSH4; 0xCA; 0xFE; 0xBA; 0xBE;
PUSH0;
MSTORE;
PUSH1; 0x03;
PUSH1; 0x02;
PUSH1; 0x01;
PUSH1; 0x20;
PUSH0;
LOG3;
}

let result = m.execute();
assert!(result.is_ok(), "execution step failed");
};
}

#[test]
fn test_log4() {
evm_unit_test! {
(rt) {
let t1 = U256::from(0x01);
let t2 = U256::from(0x02);
let t3 = U256::from(0x03);
let t4 = U256::from(0x04);
let mut data = [0u8; 32];
data[28] = 0xCA;
data[29] = 0xFE;
data[30] = 0xBA;
data[31] = 0xBE;
rt.expect_emitted_event(
ActorEvent::from(vec![
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[0].to_owned(),
value: to_vec(&t1).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[1].to_owned(),
value: to_vec(&t2).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[2].to_owned(),
value: to_vec(&t3).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_TOPIC_KEYS[3].to_owned(),
value: to_vec(&t4).unwrap().into(),
},
Entry{
flags: Flags::FLAG_INDEXED_ALL,
key: EVENT_DATA_KEY.to_owned(),
value: RawBytes::serialize(BytesSer(&data)).unwrap(),
}
])
);
}

(m) {
PUSH4; 0xCA; 0xFE; 0xBA; 0xBE;
PUSH0;
MSTORE;
PUSH1; 0x04;
PUSH1; 0x03;
PUSH1; 0x02;
PUSH1; 0x01;
PUSH1; 0x20;
PUSH0;
LOG4;
}

let result = m.execute();
assert!(result.is_ok(), "execution step failed");
};
}
}
54 changes: 54 additions & 0 deletions actors/evm/src/interpreter/instructions/storage.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,57 @@ pub fn sstore(

system.set_storage(key, value)
}

#[cfg(test)]
mod tests {
use fil_actors_evm_shared::uints::U256;

use crate::evm_unit_test;

#[test]
fn test_sload() {
// happy path
evm_unit_test! {
(m) {
SLOAD;
}
m.system.set_storage(U256::from(0), U256::from(0x42)).unwrap();
m.state.stack.push(U256::from(0)).unwrap();
let result = m.step();
assert!(result.is_ok(), "execution step failed");
assert_eq!(m.state.stack.len(), 1);
assert_eq!(m.state.stack.pop().unwrap(), U256::from(0x42));
};
}

#[test]
fn test_sload_oob() {
// oob access -- it is a zero
evm_unit_test! {
(m) {
SLOAD;
}
m.state.stack.push(U256::from(1234)).unwrap();
let result = m.step();
assert!(result.is_ok(), "execution step failed");
assert_eq!(m.state.stack.len(), 1);
assert_eq!(m.state.stack.pop().unwrap(), U256::from(0));
};
}

#[test]
fn test_sstore() {
evm_unit_test! {
(m) {
SSTORE;
}

m.state.stack.push(U256::from(0x42)).unwrap();
m.state.stack.push(U256::from(0)).unwrap();
let result = m.step();
assert!(result.is_ok(), "execution step failed");
assert_eq!(m.state.stack.len(), 0);
assert_eq!(m.system.get_storage(U256::from(0)).unwrap(), U256::from(0x42));
};
}
}
2 changes: 2 additions & 0 deletions actors/evm/src/interpreter/test_util.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ macro_rules! evm_unit_test {

let mut system = System::new(&mut $rt, false);
let bytecode = Bytecode::new(code);
#[allow(unused_mut)]
let mut $machine = Machine {
system: &mut system,
state: &mut state,
Expand Down Expand Up @@ -63,6 +64,7 @@ macro_rules! evm_unit_test {

let mut system = System::new(&mut rt, false);
let bytecode = Bytecode::new(code);
#[allow(unused_mut)]
let mut $machine = Machine {
system: &mut system,
state: &mut state,
Expand Down

0 comments on commit c5cbd5b

Please sign in to comment.