Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass block limits through to link budgets #175

Open
hannahhoward opened this issue Apr 3, 2023 · 0 comments
Open

Pass block limits through to link budgets #175

hannahhoward opened this issue Apr 3, 2023 · 0 comments
Assignees

Comments

@hannahhoward
Copy link
Collaborator

What

Since deploying parallel bitswap, we're seeing a huge spike in size of requested content from upstream providers.

I think this is cause Block Limits are really functioning the way we expect them to with preloading. Currently, we handle block limits directly in the HTTP handler / CAR streaming layer with the LimitStore. This worked when link loading matched 1:1 with sending blocks over the wire. But with the preloader, we can now load potentially infinite numbers of links ahead of time without affecting the blocks on the wire. We should pass the block limit into the link budgets used in Bitswap somehow (or maybe put the limit store on top of the preload store as well?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants