Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This adds a query parameter which can be used multiple times, called "peer-filter". The syntax for the value is: peer id as string + optional
~
followed by comma seperated protocol listSo:
QmPeerIDFoo~bitswap
orQmPeerIDFoo~bitswap,graphsync
or justQmPeerIDFoo
. If no~
is present the peer is filtered entirely. If ~ is present, the specified list of protocols are filtered out.This is my proposed solution for #207 but want to get buy in before I put in all the tests.
between this, the "protocols" param, and the "providers" param, this should enable us to do various A-B test experiments with Saturn, and also provides a solution for eIPFS bitswap filtered.
I'd rather leave percentages to Saturn code specifically to do dice rolling on its own.