Add more error handling to resolve lint-errors

filecoin-project · May 28, 2024 · 8e1c87d · 8e1c87d
1 parent 5ffb88a
commit 8e1c87d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/cli/client.go b/cli/client.go
@@ -2319,7 +2319,10 @@ func OutputDataTransferChannels(out io.Writer, channels []lapi.DataTransferChann
 		}
 	}
 
-	fmt.Fprintf(out, "Sending Channels\n\n")
+	if _, err := fmt.Fprintf(out, "Sending Channels\n\n"); err != nil {
+		fmt.Fprintf(os.Stderr, "Error writing to output: %v\n", err)
+		return
+	}
 	w := tablewriter.New(tablewriter.Col("ID"),
 		tablewriter.Col("Status"),
 		tablewriter.Col("Sending To"),

diff --git a/cli/multisig.go b/cli/multisig.go
@@ -332,7 +332,9 @@ var msigInspectCmd = &cli.Command{
 			})
 
 			w := tabwriter.NewWriter(cctx.App.Writer, 8, 4, 2, ' ', 0)
-			fmt.Fprintf(w, "ID\tState\tApprovals\tTo\tValue\tMethod\tParams\n")
+			if _, err := fmt.Fprintf(w, "ID\tState\tApprovals\tTo\tValue\tMethod\tParams\n"); err != nil {
+				return err
+			}
 			for _, txid := range txids {
 				tx := pending[txid]
 				target := tx.To.String()
@@ -344,9 +346,13 @@ var msigInspectCmd = &cli.Command{
 
 				if err != nil {
 					if tx.Method == 0 {
-						fmt.Fprintf(w, "%d\t%s\t%d\t%s\t%s\t%s(%d)\t%s\n", txid, "pending", len(tx.Approved), target, types.FIL(tx.Value), "Send", tx.Method, paramStr)
+						if _, err := fmt.Fprintf(w, "%d\t%s\t%d\t%s\t%s\t%s(%d)\t%s\n", txid, "pending", len(tx.Approved), target, types.FIL(tx.Value), "Send", tx.Method, paramStr); err != nil {
+							return err
+						}
 					} else {
-						fmt.Fprintf(w, "%d\t%s\t%d\t%s\t%s\t%s(%d)\t%s\n", txid, "pending", len(tx.Approved), target, types.FIL(tx.Value), "new account, unknown method", tx.Method, paramStr)
+						if _, err := fmt.Fprintf(w, "%d\t%s\t%d\t%s\t%s\t%s(%d)\t%s\n", txid, "pending", len(tx.Approved), target, types.FIL(tx.Value), "new account, unknown method", tx.Method, paramStr); err != nil {
+							return err
+						}
 					}
 				} else {
 					method := consensus.NewActorRegistry().Methods[targAct.Code][tx.Method] // TODO: use remote map
@@ -365,7 +371,9 @@ var msigInspectCmd = &cli.Command{
 						paramStr = string(b)
 					}
 
-					fmt.Fprintf(w, "%d\t%s\t%d\t%s\t%s\t%s(%d)\t%s\n", txid, "pending", len(tx.Approved), target, types.FIL(tx.Value), method.Name, tx.Method, paramStr)
+					if _, err := fmt.Fprintf(w, "%d\t%s\t%d\t%s\t%s\t%s(%d)\t%s\n", txid, "pending", len(tx.Approved), target, types.FIL(tx.Value), method.Name, tx.Method, paramStr); err != nil {
+						return err
+					}
 				}
 			}
 			if err := w.Flush(); err != nil {