Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Migration Test for FIP-0085 in Lotus to Assert New State of f090 #12102

Closed
rjan90 opened this issue Jun 17, 2024 · 3 comments
Closed

Create Migration Test for FIP-0085 in Lotus to Assert New State of f090 #12102

rjan90 opened this issue Jun 17, 2024 · 3 comments
Assignees

Comments

@rjan90
Copy link
Contributor

rjan90 commented Jun 17, 2024

Done Criteria

  1. A migration test is created in Lotus to assert the new state of f090 as per FIP-0085.
  2. The test verifies that f090 has been converted from a multisig actor to a keyless account actor.
  3. The test is integrated into the existing Lotus test suite and passes all checks.

Why Important

  1. Ensures that the migration of f090 to a keyless account actor is correctly implemented and verifiable.
  2. Prevents potential issues that could arise from the migration by catching them early in the testing phase.
  3. Provides a clear and automated way to verify the state of f090, reducing the risk of human error.

User/Customer

Maintainers and developers working on the Lotus project.

Notes

  1. The migration of f090 is detailed in FIP-0085](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0085.md).
  2. The PR adding the migration can be found here.
  3. Ensure that the test covers all edge cases and scenarios outlined in the FIP.
  4. Coordinate with the team to integrate the test into the CI/CD pipeline for continuous verification.
@rjan90 rjan90 added this to FilOz Jun 17, 2024
@rjan90 rjan90 moved this to 🐱Todo in FilOz Jun 17, 2024
@rjan90 rjan90 moved this from 🐱Todo to 📌 Triage in FilOz Jun 18, 2024
@rjan90 rjan90 moved this from 📌 Triage to 🐱Todo in FilOz Jun 18, 2024
@BigLep
Copy link
Member

BigLep commented Jun 24, 2024

#fil-lotus-dev slack thread: https://filecoinproject.slack.com/archives/CP50PPW2X/p1718627270414419

I'm working to make sure we complete this by EOD 2024-06-26.

@BigLep
Copy link
Member

BigLep commented Jun 24, 2024

Per Slack, @ZenGround0 is going to take this with goal to land before the Lotus 1.28.0 RC.

@BigLep BigLep moved this from 🥞 Todo to ✅ Done in nv23 Track Board Jun 25, 2024
@BigLep BigLep moved this from 🐱Todo to 🎉 Done in FilOz Jun 25, 2024
@BigLep
Copy link
Member

BigLep commented Jun 25, 2024

Closing given #12139 was merged

@BigLep BigLep closed this as completed Jun 25, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️Done (Archive) in FilOz Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Status: ✅ Done
Development

No branches or pull requests

4 participants