Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: add harmony machine name column #12048

Closed
wants to merge 1 commit into from

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented May 27, 2024

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link

github-actions bot commented May 27, 2024

All checks have completed

❌ Failed Check / Check (lint-all) (pull_request)
❌ Failed Test / Test (itest-path_type_filters) (pull_request)

@snadrus snadrus self-requested a review May 27, 2024 13:50
Copy link
Collaborator

@snadrus snadrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the column in the same pr you add it

@LexLuthr LexLuthr force-pushed the curio-machine-name branch from a538556 to 917be43 Compare May 27, 2024 13:59
@LexLuthr
Copy link
Contributor Author

@snadrus HarmonyDB is residing in Lotus repo and my PR will be against Curio repo. Thus this weird 1 line change in Lotus.

@LexLuthr
Copy link
Contributor Author

Closing as we are now migrating HarmonyDB.

@LexLuthr LexLuthr closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants