Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ec: Integrate Fast Finality for Filecoin #12119

Merged
merged 32 commits into from
Jun 28, 2024
Merged

feat: ec: Integrate Fast Finality for Filecoin #12119

merged 32 commits into from
Jun 28, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Jun 19, 2024 •
edited by masih
Loading

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Kubuxu added 6 commits June 19, 2024 19:13
@Kubuxu
F3 WIP
5861704 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Expose F3Participate API, general cleanup
3c2f783 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Remove replace directive
10660a0 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Skip to the end of the loop in case of broadcast failures
128f47b 
,
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
make gen
12b1a5e 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Don't upgrade urfave/cli
68a5e6e 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@filecoin-project filecoin-project deleted a comment from github-actions bot Jun 22, 2024
This was referenced Jun 22, 2024
Closed
Closed
Closed
@Kubuxu
Add F3GetCertificate and F3GetLatestCertificate
0b303ca 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu Kubuxu marked this pull request as ready for review June 24, 2024 02:23
@Kubuxu Kubuxu changed the title (WIP) Integrate Fast Finality for Filecoin Integrate Fast Finality for Filecoin Jun 24, 2024
@Kubuxu Kubuxu requested a review from Stebalien June 24, 2024 10:22
masih
masih reviewed Jun 24, 2024
View reviewed changes
api/api_full.go Outdated Show resolved Hide resolved
chain/lf3/ec.go Outdated Show resolved Hide resolved
chain/lf3/ec.go Show resolved Hide resolved
chain/lf3/f3.go Outdated Show resolved Hide resolved
chain/lf3/f3.go Outdated Show resolved Hide resolved
chain/lf3/f3.go Outdated Show resolved Hide resolved
chain/lf3/signer.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
node/builder_chain.go Outdated Show resolved Hide resolved
node/modules/storageminer.go Outdated Show resolved Hide resolved
Kubuxu added 3 commits June 24, 2024 17:00
@Kubuxu
Cleanup, network params, change the behaviour of F3Participate
d3245a4 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Update to go-f3@main
bef79be 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Add one more context guard
75a917e 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Kubuxu added 2 commits June 24, 2024 17:14
@Kubuxu
Fix building
c404a6d 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
make gen
919ae0f 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Add a log, don't start F3Participation if built without F3
791621b 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Resolve errors
9a7f0f2 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
Add additional checks for miner power
9689014 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

All checks have passed

@Stebalien
Copy link
Member

I've addressed most of my own comments, but there are a few outstanding ones.

aarshkshah1992
aarshkshah1992 reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass review. Doing one more deeper round now.

api/api_full.go Show resolved Hide resolved
build/params_calibnet.go Show resolved Hide resolved
chain/lf3/ec.go Show resolved Hide resolved
chain/lf3/f3.go Show resolved Hide resolved
node/impl/full/f3.go Show resolved Hide resolved
node/modules/storageminer.go Outdated Show resolved Hide resolved
node/modules/lp2p/pubsub.go Outdated Show resolved Hide resolved
aarshkshah1992
aarshkshah1992 reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

node/builder_chain.go Show resolved Hide resolved
api/api_full.go Show resolved Hide resolved
build/params_mainnet.go Show resolved Hide resolved
node/modules/storageminer.go Show resolved Hide resolved
aarshkshah1992
aarshkshah1992 reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished my review.

@aarshkshah1992
Copy link
Contributor

@BigLep I have reviewed this one.

@masih masih mentioned this pull request Jun 28, 2024
Closed
@masih masih changed the title Integrate Fast Finality for Filecoin feat: ec: Integrate Fast Finality for Filecoin Jun 28, 2024
Stebalien
Stebalien approved these changes Jun 28, 2024
View reviewed changes
chain/lf3/f3.go Outdated Show resolved Hide resolved
chain/lf3/f3.go Outdated Show resolved Hide resolved
@Stebalien Stebalien enabled auto-merge (squash) June 28, 2024 17:09
@Stebalien Stebalien merged commit 7cdf9aa into master Jun 28, 2024
78 checks passed
@Stebalien Stebalien deleted the feat/f3 branch June 28, 2024 17:11
aarshkshah1992 pushed a commit that referenced this pull request Jul 1, 2024
@Kubuxu @jennijuju
@masih @Stebalien @aarshkshah1992
feat: ec: Integrate Fast Finality for Filecoin (#12119)
41887b7 
Integrate F3 into Lotus

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: Jennifer Wang <jiayingw703@gmail.com>
Co-authored-by: Masih H. Derkani <m@derkani.org>
Co-authored-by: Steven Allen <steven@stebalien.com>
@aarshkshah1992 aarshkshah1992 mentioned this pull request Jul 1, 2024
Merged
aarshkshah1992 pushed a commit that referenced this pull request Jul 1, 2024
@Kubuxu @jennijuju
@masih @Stebalien @aarshkshah1992
feat: ec: Integrate Fast Finality for Filecoin (#12119)
ac87fce 
Integrate F3 into Lotus

Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Co-authored-by: Jennifer Wang <jiayingw703@gmail.com>
Co-authored-by: Masih H. Derkani <m@derkani.org>
Co-authored-by: Steven Allen <steven@stebalien.com>
@aarshkshah1992
Copy link
Contributor

Backported in #12168.

@ruseinov ruseinov mentioned this pull request Jul 22, 2024
Open
18 tasks
@rjan90 rjan90 mentioned this pull request Aug 31, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennijuju jennijuju jennijuju left review comments

@masih masih masih left review comments

@aarshkshah1992 aarshkshah1992 aarshkshah1992 approved these changes

@Stebalien Stebalien Stebalien approved these changes

@rvagg rvagg Awaiting requested review from rvagg

Assignees

@masih masih

Labels
None yet
Projects
No open projects
nv23 Track Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kubuxu @BigLep @Stebalien @aarshkshah1992 @masih @rvagg @jennijuju