build: release: v1.28.0 #12271

rjan90 · 2024-07-22T11:32:05Z

Proposed Changes

Prep for cutting stable v1.28.0

Backports:

Checklist

Before you mark the PR ready for review, please make sure that:

Commits have a clear commit message.
PR title is in the form of of <PR type>: <area>: <change being made>
- example: fix: mempool: Introduce a cache for valid signatures
- PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
- area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
Update CHANGELOG.md or signal that this change does not need it.
- If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
- If the change does not require a CHANGELOG.md entry, do one of the following:
  - Add [skip changelog] to the PR title
  - Add the label skip/changelog to the PR
New features have usage guidelines and / or documentation updates in
- Lotus Documentation
- Discussion Tutorials
Tests exist for new functionality or change in behavior
CI is green

Update changelog

* Add support for nv23 in `lotus-shed migrate-state` cmd Add support for nv23 in `lotus-shed migrate-state` cmd * Add actors v14 to `check-invariants` cmd Add actors v14 to `check-invariants` cmd

Use concrete/latest version of F3: v0.0.3

Upgrade to new version of OpenTelemetry to also play nice with F3.

Reduce the log level for `miner with id...` to DEBUG, since in normal operation of F3 at least 5 messages are sent per epoch. In an event of rebroadcast the number of messages broadcasted could surpass 10. Hence, the `DEBUG` log level.

Upgrade to the latest go F3, with fix to default cert exchange config in local devnet.

@rjan90

@rjan90 and @jennijuju reported seeing this log a lot, which prompted an investigation of the logic. This code does not implement [FIP-0023](https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0023.md) correctly. Specifically, if we have the following mintickets: ``` ts1: 1, 2 ts2: 0,3 ``` This code will incorrectly return ts1 as the "smaller" tipset, even though the tie should have been broken in favour of ts2 based on `1 > 0`.

Fix lint error: correct typo in F3Participation function comment

Corrected "successfull" to "successful" in comments and documentation to fix a lint error.

go mod tidy

BigLep

I know this is in draft and hasn't had a review request yet. I just left a couple of comments of things that saw in the CHANGELOG.

CHANGELOG.md

Co-authored-by: Steve Loeppky <biglep@protocol.ai>

Set Mainnet upgrade epoch NV23

Update changelog.md

BigLep · 2024-07-23T19:46:18Z

@rjan90 : is #12248 making the cut?

rjan90 · 2024-07-23T19:48:56Z

@rjan90 : is #12248 making the cut?

No, I suggest we drop that backport since it is not critical. Then the ascii-art can be an easter-egg for those running the master branch instead during the network upgrade :D

…23 (#12276) * Update to final GST for nv23 Update to final GST for nv23 * Bump filecoin-ffi to v1.28.0 Bump filecoin-ffi to v1.28.0 * Update CHANGELOG.md Update CHANGELOG.md * Update Builtin-actors to v14.0.0 Update Builtin-actors to v14.0.0

Update Changelog, version-string, make gen and make docsgen

rjan90 · 2024-07-23T20:16:56Z

Waiting on this PR to be ready, as it needs to be backported - but opening for reviews in the meantime:

chore: f3: Upgrade to go-f3 v0.0.5 #12279

build/builtin_actors_gen.go

Re-run ./pack.sh v14 v14.0.0

Register otel collector bridging to the default prometheus registry so that F3 metrics (which use the newer otel APIs for metrics) get included in Lotus metrics.

Update changelog with #12285 backport

aarshkshah1992 · 2024-07-24T07:06:14Z

@rjan90

fix: Eth Trace Block: nil access panic #12221 has not been backported even though we've mentioned it here
I don't think we should be backporting chore!: markets: remove stray unixfs constants, features and references #12217 AND [skip changelog] chore: config: yet more lp2p removal from miner #12252. They haven't been tested on Calibnet and are only cleanup changes so they can wait till the next release where they get exercised on calibnet and butterfly.

rvagg · 2024-07-24T07:13:17Z

A gentle +1 to removing those 2 additional backports - the first one was labelled mainly because it coupled with #12112 and it was originally marked for backporting but was subsequently unmarked. #12252 is not really critical either, even though it does nicely clean up the config file a bit more.

But fwiw I'm running both my mainnet and calibnet nodes on #12288 which is on top of this and it seems to be fine.

rjan90 · 2024-07-24T07:28:11Z

A gentle +1 to removing those 2 additional backports

Yeah, I will remove those.

ribasushi · 2024-07-24T07:32:54Z

@rjan90 @rvagg @aarshkshah1992 If you end up reverting #12252 you will be knowingly reintroducing a configuration stack for a subsystem that does not exist. 2 minutes before the release.

This is not... smart.

This reverts commit d045ccb.

This reverts commit 70400c9.

rjan90 · 2024-07-24T08:18:37Z

@rjan90 @rvagg @aarshkshah1992 If you end up reverting #12252 you will be knowingly reintroducing a configuration stack for a subsystem that does not exist. 2 minutes before the release.

This is not... smart.

Given our lengthy release cycles for network upgrades and the desire to minimize changes, even if it means temporarily retaining something like a stray config.

At this stage, with the majority advocating for removing the backport, I don't believe this is worth debating further. Our priority should be to get this release out, so that teams can begin integrating the NV23 changes into their stacks before the network upgrade, we can always address those cleanups in the next release.

* chore: f3: Upgrade to go-f3 `v0.0.5` (#12279) * Upgrade to go-f3 `v0.0.5` Upgrade to the latest version of go-f3 with initial power table storage with far enough lookback, and dynamic manifest persistence. --------- Co-authored-by: Jakub Sztandera <oss@kubuxu.com> Co-authored-by: Jiaying Wang <42981373+jennijuju@users.noreply.github.com> Co-authored-by: Steven Allen <steven@stebalien.com> * remove unwanted changelog * fix import * Revert "chore!: markets: remove deal constants" This reverts commit d045ccb. * Revert "chore: config: yet more lp2p removal from miner" This reverts commit 70400c9. * fix eth trace panic * Update CHANGELOG.md Co-authored-by: Jakub Sztandera <oss@kubuxu.com> * Update CHANGELOG.md --------- Co-authored-by: Masih H. Derkani <m@derkani.org> Co-authored-by: Jakub Sztandera <oss@kubuxu.com> Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: Phi <orjan.roren@gmail.com> Co-authored-by: aarshkshah1992 <aarshkshah1992@gmail.com>

rjan90 and others added 16 commits July 22, 2024 13:30

Update changelog

33d0861

Update changelog

chore: lotus-shed: Add support for nv23 in migrate-state cmd (#12172)

21f8f95

* Add support for nv23 in `lotus-shed migrate-state` cmd Add support for nv23 in `lotus-shed migrate-state` cmd * Add actors v14 to `check-invariants` cmd Add actors v14 to `check-invariants` cmd

feat: F3: Update go-f3, change the style of participation call (#12196)

d04884b

Upgrade go mod F3 dependency to v0.0.3 tagged release

de98b0c

Use concrete/latest version of F3: v0.0.3

update changelog

f431213

chore!: markets: remove deal constants

d045ccb

Upgrade to OpenTelemetry v1.28.0

4af57bd

Upgrade to new version of OpenTelemetry to also play nice with F3.

chore: deps: upgrade to go-state-types@v0.14.0-rc6

8d02e05

Upgrade to latest go-f3 v0.0.4 (#12237)

22779e6

Upgrade to the latest go F3, with fix to default cert exchange config in local devnet.

chore: config: yet more lp2p removal from miner

70400c9

Fix lint error: correct typo in F3Participation function comment

742c43d

Fix lint error: correct typo in F3Participation function comment

Fix typo in F3Participate documentation

aafc8de

Corrected "successfull" to "successful" in comments and documentation to fix a lint error.

chore: libp2p: update to v0.35.4 (#12265)

0375363

go mod tidy

a174046

go mod tidy

BigLep reviewed Jul 22, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

rjan90 and others added 3 commits July 23, 2024 10:47

Update CHANGELOG.md

21e7446

Co-authored-by: Steve Loeppky <biglep@protocol.ai>

fix a bug

9e9403b

Set Mainnet upgrade epoch NV23

2cb46a9

Set Mainnet upgrade epoch NV23

rjan90 mentioned this pull request Jul 23, 2024

chore: Set Mainnet upgrade epoch for NV23 #12278

Merged

8 tasks

Update changelog.md

9ce1042

Update changelog.md

rjan90 added 2 commits July 23, 2024 21:56

Update Changelog, version-string, make gen and make docsgen

05d588a

Update Changelog, version-string, make gen and make docsgen

rjan90 marked this pull request as ready for review July 23, 2024 20:16

ribasushi reviewed Jul 23, 2024

View reviewed changes

build/builtin_actors_gen.go Outdated Show resolved Hide resolved

Re-run ./pack.sh v14 v14.0.0

5f70d87

Re-run ./pack.sh v14 v14.0.0

BigLep mentioned this pull request Jul 23, 2024

[WIP] Lotus Release v1.28.0 #12109

Closed

55 tasks

masih and others added 2 commits July 24, 2024 00:15

Set up otel metrics reporting to prometheus

0804992

Register otel collector bridging to the default prometheus registry so that F3 metrics (which use the newer otel APIs for metrics) get included in Lotus metrics.

Update changelog with #12285 backport

93b484f

Update changelog with #12285 backport

rjan90 requested a review from aarshkshah1992 July 24, 2024 06:49

rjan90 and others added 3 commits July 24, 2024 09:38

Revert "chore!: markets: remove deal constants"

f8a75ab

This reverts commit d045ccb.

Revert "chore: config: yet more lp2p removal from miner"

a0947ab

This reverts commit 70400c9.

fix eth trace panic

12ca19a

aarshkshah1992 approved these changes Jul 24, 2024

View reviewed changes

rjan90 mentioned this pull request Jul 24, 2024

misc: add waffle to match w/ forest #12248

Closed

rjan90 merged commit 28a578f into release/v1.28.0 Jul 24, 2024
78 checks passed

rjan90 deleted the phi/v1280-stable branch July 24, 2024 10:36

ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Jul 24, 2024

undo mess from filecoin-project#12271

899d78c

rvagg mentioned this pull request Jul 25, 2024

chore: merge v1.28.1 release back to master & update master version to v1.28.2-dev #12306

Closed

ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 17, 2024

undo mess from filecoin-project#12271

1bf1f0d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: release: v1.28.0 #12271

build: release: v1.28.0 #12271

rjan90 commented Jul 22, 2024 •

edited

Loading

BigLep left a comment

BigLep commented Jul 23, 2024

rjan90 commented Jul 23, 2024

rjan90 commented Jul 23, 2024

aarshkshah1992 commented Jul 24, 2024 •

edited

Loading

rvagg commented Jul 24, 2024

rjan90 commented Jul 24, 2024

ribasushi commented Jul 24, 2024

rjan90 commented Jul 24, 2024 •

edited

Loading

build: release: v1.28.0 #12271

build: release: v1.28.0 #12271

Conversation

rjan90 commented Jul 22, 2024 • edited Loading

Proposed Changes

Checklist

BigLep left a comment

Choose a reason for hiding this comment

BigLep commented Jul 23, 2024

rjan90 commented Jul 23, 2024

rjan90 commented Jul 23, 2024

aarshkshah1992 commented Jul 24, 2024 • edited Loading

rvagg commented Jul 24, 2024

rjan90 commented Jul 24, 2024

ribasushi commented Jul 24, 2024

rjan90 commented Jul 24, 2024 • edited Loading

rjan90 commented Jul 22, 2024 •

edited

Loading

aarshkshah1992 commented Jul 24, 2024 •

edited

Loading

rjan90 commented Jul 24, 2024 •

edited

Loading