Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): enhance ChainListCmd with JSON output and <epoch> placeholder support #12691

Merged
merged 11 commits into from
Dec 6, 2024
Merged

feat(cli): enhance ChainListCmd with JSON output and <epoch> placeholder support #12691

merged 11 commits into from
Dec 6, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Nov 12, 2024

This PR updates the ChainListCmd with:

  • JSON output via <json_tipset> for compact tipset representation.
  • Support for <epoch> as a placeholder.
  • Streamlined format flag usage documentation.

@Kubuxu
docs: Update format flag usage with valid placeholders for ChainListCmd
2ff1ec3 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
feat: Add <json_tipset> placeholder for JSON encoding of the tipset
e7f7c70 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
style: Fix formatting in chain.go for consistency and readability
d53baa9 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
fix: Change JSON encoding to single line without indentation
0cf9f8c 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
docs: Update Usage for format flag to remove placeholder explanations
58d77af 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
feat: Rename 'height' flag to 'epoch' in ChainListCmd and update usage
4465f0a 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu
add changelog
abbb75b 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu Kubuxu force-pushed the feat/better-list-formats branch from 5d26a70 to abbb75b Compare November 12, 2024 10:48
@Kubuxu
docs: Update CLI options in lotus documentation for clarity and detail
c01f8db 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
rvagg
rvagg approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, although just a --json that's mutually exclusive with --format might make this eaiser

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Nov 18, 2024

I would expect --json to probably return block headers, which is not what I wanted here. I needed a nice way to resolve epoch to JSON tipset in API format to call louts-shed rpc with it.

@Kubuxu Kubuxu enabled auto-merge (squash) December 6, 2024 14:51
@Kubuxu Kubuxu disabled auto-merge December 6, 2024 14:51
@Kubuxu
fix changelog
eb63f5d 
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
@Kubuxu Kubuxu merged commit 6347eff into master Dec 6, 2024
83 checks passed
@Kubuxu Kubuxu deleted the feat/better-list-formats branch December 6, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @rvagg