-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load more source lines #205
Comments
We can't do that with ajax. What we'd have to do is send the whole file the first time round, then get js to only show part of it. This could be an issue if the file is very large because we'd be loading a lot into memory. |
Right, using ajax would require some machinery (similar to #42). Maybe we could send some more lines (not all) so a dev could expand 2-3 (or configurable?) times into both directions |
I like that idea. Maybe if we could expand 50 lines either way or something? |
Will give it a try... Maybe I get something prepared on monday |
I played with this feature a bit, but it is not that easy to implement. I tried reading more lines then initially visible and toggle them using Zeptos' It felt like Atm I have no further idea how to implement it, without a roundtrip to the server and re-rendering (like github does). But therefore we would need to establish a connection/socket to the client which isn't that easy either. |
Closing due to inactivity. If anyone wants to work on this, feel free to speak up. |
Like in github diff views, it would be great if one could load more source lines into the pretty error page
The text was updated successfully, but these errors were encountered: