Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bitrate command line argument to control bitrate of output video #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Netruk44
Copy link

Support for specifying a bit rate for the output video file on the command line (--bitrate)

Potential fix for #19

@Netruk44
Copy link
Author

Note that this is just what worked for my specific use case. It looks like this probably does nothing for 2D video upscaling, but I'm not sure how best to add that.

Feel free to close the PR without merging if this isn't the way you want to go about doing this kind of thing :)

@Netruk44
Copy link
Author

Netruk44 commented Jun 29, 2024

Adding a note here that there's also an alternative implementation available on my auto-bitrate branch: https://github.com/Netruk44/fx-upscale/tree/auto-bitrate

This version automatically calculates a bitrate for the 3D video if one hasn't been passed in on the command line.

I can make a PR with that branch instead, if you prefer that implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant