Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "internal-network" to be "network" #191

Closed
jpgough-ms opened this issue May 13, 2024 · 1 comment
Closed

Update "internal-network" to be "network" #191

jpgough-ms opened this issue May 13, 2024 · 1 comment
Assignees
@jpgough-ms
Labels
CALM Generator Pattern Instantiation Generator Validator

Comments

@jpgough-ms
Copy link
Member

Feature Request

Whilst reviewing CALM we noticed that internal-network is too specific as a node-type-definition it should be changed to network and the node created can carry more information regarding whether it is internal/external/cloud etc
@jpgough-ms jpgough-ms added CALM Validator Generator Pattern Instantiation Generator labels May 13, 2024
@jpgough-ms jpgough-ms self-assigned this May 13, 2024
jpgough-ms added a commit to jpgough-ms/architecture-as-code that referenced this issue May 13, 2024
@jpgough-ms
finos#191 Update internal-network to network
eb33ceb
jpgough-ms added a commit to jpgough-ms/architecture-as-code that referenced this issue May 13, 2024
@jpgough-ms
finos#191 Pick up new schema in translator build
f537dd0
rocketstack-matt added a commit that referenced this issue Jun 3, 2024
@Budlee @jpgough-ms @rocketstack-matt
Jamespg network fix (#259)
9f5bd27 
* #191 Update internal-network to network

* #191 Pick up new schema in translator build

* Fix translator to work with new network and interface

---------

Co-authored-by: Jim Gough <james.gough@morganstanley.com>
Co-authored-by: Matthew Bain <66839492+rocketstack-matt@users.noreply.github.com>
Co-authored-by: jpgough-ms <152306432+jpgough-ms@users.noreply.github.com>
@rocketstack-matt
Copy link
Member

@jpgough-ms can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpgough-ms jpgough-ms

Labels
CALM Generator Pattern Instantiation Generator Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rocketstack-matt @jpgough-ms