#48 Remove mandatory interface on connects relationship #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2024
rocketstack-matt
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
We will discuss further how we want to support use of CALM as a modelling tool vs. instantiation / control mechanism further, but for now approving this change to provide maximum flexibility.
If we were to build a security control capability over CALM it would likely need to differentiate between logical vs. physical architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #106 we have decided to make interfaces optional on a relationship for now. If it was mandatory that would remove the ability to use CALM as a logical tool and mean that it is only a physical modelling tool.
We may need to consider whether we have a convention to mark what type of diagram this is