Add spectral rules to check patterns #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willosborne
force-pushed
the
spectral-spike
branch
2 times, most recently
from
b633233
to
46eece9
Compare
jpgough-ms
requested changes
Apr 18, 2024
willosborne
force-pushed
the
spectral-spike
branch
from
46eece9
to
38d9e42
Compare
lbulanti-ms
approved these changes
Apr 18, 2024
grahampacker-ms
approved these changes
Apr 18, 2024
|
@jpgough-ms this is pending you resolving the change requests I believe |
grahampacker-ms
force-pushed
the
spectral-spike
branch
from
f232b40
to
8ad5de2
Compare
jpgough-ms
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this also includes a script to strip $refs from patterns before validation. This is necessary as spectral isn't too smart about $refs and will aggressively follow them.
CLI also needs to be updated to run these checks, I will do this later