-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Visualizer to use GraphViz #144
Conversation
@@ -25,7 +25,9 @@ | |||
"ajv": "^8.12.0", | |||
"commander": "^12.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we removing Mermaid now that it's no longer needed? That should remove the dependency on Playwright/puppeteer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, I'll do a follow up PR to remove all the old visualizer code once this is all merged in and done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitely go into a shared module eventually. Other projects should be re-using this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. I'll just move it now so it's done
} | ||
|
||
function addRelationship(g: Digraph, relationship: CALMRelationship): void { | ||
if ('connects' in relationship['relationship-type']) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we potentially add methods to work on relationship types such as .getRelationshipType now that we have a model for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought, this works fine
In order to get visualisation working on the CLI without the use of a headless browser, I have switched to using GraphViz.
I've also moved the visualisation code into the CLI folder directly to facilitate publishing it to NPM.