visualizer works with patterns #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanm3341
requested review from
lbulanti-ms,
willosborne,
grahampacker-ms and
a team
as code owners
aidanm3341
changed the title
aidanm3341
changed the title
lbulanti-ms
reviewed
Apr 19, 2024
lbulanti-ms
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the existing functionality to generate an instantiation of a pattern, I have extended the visualizer to take a pattern and turn into an instantiation and then using the existing visualisation logic to draw it.
I've also fixed some issues in the examples (e.g. nodes was used instead of node)
fixes (#100)