Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Implementation of UUID Custom Type #163

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

cnieves81
Copy link
Contributor

@cnieves81 cnieves81 commented May 16, 2024

Effectively, this PR is a wrapper around https://github.com/47degrees/memeid

Not every feature has been imported/wrapped. But, this PR should enable basic usage of UUID V1, V3, V4, and V5. There is an opportunity to extend the functionality to allow for utilizing other objects besides strings for UUID V3 and V5, but that does require some more work as the memeid library relies on an additional custom type Digestible

@cnieves81 cnieves81 changed the title UUID custom type Initial Implementation of UUID Custom Type May 16, 2024
@cnieves81 cnieves81 marked this pull request as ready for review May 16, 2024 14:54
@DamianReeves
Copy link
Member

I notice quite a few of the functions available for the UUID module in Elm is not available here, is that intentional?

@cnieves81
Copy link
Contributor Author

@DamianReeves I added a commit with a few static namespaces + the nil check that is present in the Elm Module.

The UUID Type I'm wrapping does expose version and compare methods, but they are accessed on a UUID instance via:

uuid.version and uuid1.compare(uuid2) rather than elm's implementation which if I'm understanding correctly is accessed via version uuid and compare uuid1 uuid2, where the uuid is being passed in as a parameter to a static method. I could probably reimplement something closer to the latter if necessary.

@DamianReeves DamianReeves merged commit 8940c53 into finos:main Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants