From e0d7182c7f1d60005496be3f7668507510543d51 Mon Sep 17 00:00:00 2001
From: "david.watkins@db.com" <david.watkins@db.com>
Date: Wed, 17 Jul 2024 16:37:21 +0100
Subject: [PATCH 1/2] Allow Setting Descriptions to be updated

- Added description to the immutable
- Added buttons to allow user to edit description

#CTCTOWALTZ-3274
#6905
---
 .../waltz/data/settings/SettingsDao.java      |  1 +
 .../model/settings/UpdateSettingsCommand.java |  2 ++
 .../svelte/settings/SettingsAdminView.svelte  | 28 ++++++++++++++++---
 3 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/waltz-data/src/main/java/org/finos/waltz/data/settings/SettingsDao.java b/waltz-data/src/main/java/org/finos/waltz/data/settings/SettingsDao.java
index ef4d8786c..97e3bd7b8 100644
--- a/waltz-data/src/main/java/org/finos/waltz/data/settings/SettingsDao.java
+++ b/waltz-data/src/main/java/org/finos/waltz/data/settings/SettingsDao.java
@@ -91,6 +91,7 @@ public int update(UpdateSettingsCommand cmd) {
         return dsl
                 .update(SETTINGS)
                 .set(SETTINGS.VALUE, cmd.value())
+                .set(SETTINGS.DESCRIPTION, cmd.description())
                 .where(SETTINGS.NAME.eq(cmd.name()))
                 .and(SETTINGS.RESTRICTED.isFalse())
                 .execute();
diff --git a/waltz-model/src/main/java/org/finos/waltz/model/settings/UpdateSettingsCommand.java b/waltz-model/src/main/java/org/finos/waltz/model/settings/UpdateSettingsCommand.java
index 35e1234e3..9a89bb1f9 100644
--- a/waltz-model/src/main/java/org/finos/waltz/model/settings/UpdateSettingsCommand.java
+++ b/waltz-model/src/main/java/org/finos/waltz/model/settings/UpdateSettingsCommand.java
@@ -2,6 +2,7 @@
 
 import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
 import com.fasterxml.jackson.databind.annotation.JsonSerialize;
+import org.finos.waltz.model.Nullable;
 import org.finos.waltz.model.command.Command;
 import org.immutables.value.Value;
 
@@ -13,5 +14,6 @@ public abstract class UpdateSettingsCommand implements Command {
 
     public abstract String name();
     public abstract String value();
+    @Nullable public abstract String description();
 
 }
diff --git a/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte b/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte
index f61416fff..8caed1923 100644
--- a/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte
+++ b/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte
@@ -27,7 +27,7 @@
 
     $: displayedSettings  = _.isEmpty(qry)
         ? settings
-        : termSearch(settings, qry, ["name", "value", "description"])
+        : termSearch(settings, qry, ["name", "value", "description"]);
 
     $: canEdit = _.includes(user?.roles, 'ADMIN');
 
@@ -39,8 +39,9 @@
     function updateSetting() {
         const cmd = {
             name: workingSetting.name,
-            value: workingSetting.value
-        }
+            value: workingSetting.value,
+            description: workingSetting.description
+        };
 
         let updatePromise = settingsStore.update(cmd);
 
@@ -150,7 +151,26 @@
                         {/if}
                     </td>
                     <td class="text-muted">
-                        {setting.description || ""}
+                        {#if editing && workingSetting?.name === setting?.name}
+                            <input class="form-control"
+                                   id="description"
+                                   maxlength="4000"
+                                   placeholder="Description for this setting"
+                                   bind:value={workingSetting.description}/>
+                            <div style="padding-top: 1em">
+                                <button class="btn btn-success btn-xs"
+                                        disabled={workingSetting?.description === setting?.description}
+                                        on:click={() => updateSetting()}>
+                                    <Icon name="floppy-o"/> Save
+                                </button>
+                                <button class="btn btn-skinny btn-xs"
+                                        on:click={() => cancel()}>
+                                    Cancel
+                                </button>
+                            </div>
+                        {:else}
+                            {setting.description || ""}
+                        {/if}
                     </td>
                     <td>
                         {#if setting.restricted}

From 848da3b33958ba0775af648678cbb146e8c6c350 Mon Sep 17 00:00:00 2001
From: "david.watkins@db.com" <david.watkins@db.com>
Date: Thu, 18 Jul 2024 13:13:49 +0100
Subject: [PATCH 2/2] Allow Setting Descriptions to be updated

- Added description to the immutable
- Added buttons to allow user to edit description

#CTCTOWALTZ-3274
#6905
---
 .../svelte/settings/SettingsAdminView.svelte  | 102 +++++++++---------
 1 file changed, 50 insertions(+), 52 deletions(-)

diff --git a/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte b/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte
index 8caed1923..598ee5679 100644
--- a/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte
+++ b/waltz-ng/client/system/svelte/settings/SettingsAdminView.svelte
@@ -124,20 +124,21 @@
             </thead>
             <tbody>
             {#each _.orderBy(displayedSettings, d => d.name) as setting}
-                <tr class:editing={editing && workingSetting?.name === setting?.name}>
-                    <td class="text-muted">
-                        {setting.name}
-                    </td>
-                    <td>
-                        {#if editing && workingSetting?.name === setting?.name}
-                            <input class="form-control"
-                                   id="value"
-                                   maxlength="4000"
-                                   placeholder="Value for this setting"
-                                   bind:value={workingSetting.value}/>
+                {#if editing && workingSetting?.name === setting?.name}
+                    <tr class="editing">
+                        <td class="text-muted">
+                            {setting.name}
+                        </td>
+                        <td>
+                            <textarea class="form-control"
+                                      id="value"
+                                      rows="1"
+                                      maxlength="4000"
+                                      placeholder="Value for this setting"
+                                      bind:value={workingSetting.value}></textarea>
                             <div style="padding-top: 1em">
                                 <button class="btn btn-success btn-xs"
-                                        disabled={workingSetting?.value === setting?.value}
+                                        disabled={workingSetting?.value === setting?.value && workingSetting?.description === setting?.description }
                                         on:click={() => updateSetting()}>
                                     <Icon name="floppy-o"/> Save
                                 </button>
@@ -146,48 +147,45 @@
                                     Cancel
                                 </button>
                             </div>
-                        {:else}
+                        </td>
+                        <td colspan="2">
+                            <textarea class="form-control"
+                                      id="description"
+                                      rows="1"
+                                      maxlength="4000"
+                                      placeholder="Description for this setting"
+                                      bind:value={workingSetting.description}></textarea>
+
+                        </td>
+                    </tr>
+                {:else}
+                     <tr>
+                        <td class="text-muted">
+                            {setting.name}
+                        </td>
+                        <td>
                             {setting.value}
-                        {/if}
-                    </td>
-                    <td class="text-muted">
-                        {#if editing && workingSetting?.name === setting?.name}
-                            <input class="form-control"
-                                   id="description"
-                                   maxlength="4000"
-                                   placeholder="Description for this setting"
-                                   bind:value={workingSetting.description}/>
-                            <div style="padding-top: 1em">
-                                <button class="btn btn-success btn-xs"
-                                        disabled={workingSetting?.description === setting?.description}
-                                        on:click={() => updateSetting()}>
-                                    <Icon name="floppy-o"/> Save
-                                </button>
-                                <button class="btn btn-skinny btn-xs"
-                                        on:click={() => cancel()}>
-                                    Cancel
-                                </button>
-                            </div>
-                        {:else}
+                        </td>
+                        <td>
                             {setting.description || ""}
-                        {/if}
-                    </td>
-                    <td>
-                        {#if setting.restricted}
-                            <div class="text-muted"
-                                 title="This setting is restricted and cannot be edited">
-                                <Icon name="lock"/>
-                            </div>
-                        {:else }
-                            <button class="btn btn-skinny"
-                                    disabled={!canEdit || editing}
-                                    title={determineTitle(editing, canEdit)}
-                                    on:click={() => editSetting(setting)}>
-                                <Icon name="pencil"/>
-                            </button>
-                        {/if}
-                    </td>
-                </tr>
+                        </td>
+                        <td>
+                            {#if setting.restricted}
+                                <div class="text-muted"
+                                     title="This setting is restricted and cannot be edited">
+                                    <Icon name="lock"/>
+                                </div>
+                            {:else }
+                                <button class="btn btn-skinny"
+                                        disabled={!canEdit || editing}
+                                        title={determineTitle(editing, canEdit)}
+                                        on:click={() => editSetting(setting)}>
+                                    <Icon name="pencil"/>
+                                </button>
+                            {/if}
+                        </td>
+                    </tr>
+                {/if}
             {:else}
                 <tr>
                     <td colspan="4">