Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurable Ratings should allow user to assign a primary designation #6635

Closed
14 of 15 tasks
davidwatkins73 opened this issue May 31, 2023 · 0 comments
Closed
14 of 15 tasks

Measurable Ratings should allow user to assign a primary designation #6635

davidwatkins73 opened this issue May 31, 2023 · 0 comments
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Milestone
1.51

Comments

@davidwatkins73
Copy link
Member

davidwatkins73 commented May 31, 2023 •
edited
Loading

Description

We can then use it to filter/simplify views, Include in exporters, etc.

Backend

  • Add is_primary boolean column to measurable_rating table (nullable?)
  • Update DAO/Model etc
  • Doc the table changes
  • zero-one constraint will need to be implmented in app-code (don't think we can craft a database constraint as potentially multiple categories)

UI

  • Allow editors to select a single primary measurable rating for an app/category
    favourite, or tie into the drop down)
  • Group measurable rating tree - rewrite in svelte and a all-in-one backend call
  • Measurable page ratings section
  • ...others (e,g, Roadmap)

Resourcing

We intend to contribute this feature
@davidwatkins73 davidwatkins73 added the DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database label May 31, 2023
@davidwatkins73 davidwatkins73 added this to the todo : 1.51 milestone May 31, 2023
@davidwatkins73 davidwatkins73 added the noteworthy probably worth mentioning in release notes label Jun 1, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 9, 2023
@davidwatkins73
Primary rating
fb7bb8f 
finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 9, 2023
@davidwatkins73
Primary rating
dc5719d 
finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 9, 2023
@davidwatkins73
Measurable rating isPrimary editor
c2f4cfb 
- all measurable rating edit operations now have an endpoint each

finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 9, 2023
@davidwatkins73
Measurable rating isPrimary editor
7684ce2 
- all measurable rating edit operations now have an endpoint each
- tweaked screen layout to better handle narrower viewports

finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 11, 2023
@davidwatkins73
Measurable rating isPrimary editor
f5b1681 
- all measurable rating edit operations now have an endpoint each
- tweaked screen layout to better handle narrower viewports

finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 16, 2023
@davidwatkins73
Measurable rating isPrimary editor
33d9ff7 
finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 16, 2023
@davidwatkins73
Measurable rating isPrimary editor
2f9f8ba 
- allowsPrimaryRatings admin screens

finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 16, 2023
@davidwatkins73
Measurable rating isPrimary editor
b6b130a 
- allowPrimaryRatings support on edit screens

finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 16, 2023
@davidwatkins73
Measurable rating isPrimary editor
8254965 
- pulled out non angular code from the ratings browser

finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 18, 2023
@davidwatkins73
Measurable rating isPrimary editor
b81f23d 
- pulled out non angular code from the ratings browser

finos#6635
@davidwatkins73 davidwatkins73 mentioned this issue Jun 19, 2023
Closed
8 tasks
@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Jun 20, 2023
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jun 21, 2023
@db-waltz
Primary Measurable Ratings
84972f1 
- admin screens
- editor changes
- ddl

#CTCTOWALTZ-2746
finos#6635
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jun 21, 2023
@db-waltz
Primary Measurable Ratings
a259c1e 
Added isPrimary to:

- allocations extractor
- ratings extractor
- measurable explorer detail grid
- added toggle (with no back end support)

#CTCTOWALTZ-2746
finos#6635
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jun 21, 2023
@db-waltz
Primary Measurable Ratings
ae85ebf 
- side quest: updating DDL for inv kind

#CTCTOWALTZ-2746
finos#6635
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jun 21, 2023
@db-waltz
Primary Measurable Ratings
c10cd18 
- updated the ratings browser
- TODO: browser for measurables

#CTCTOWALTZ-2746
finos#6635
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jun 21, 2023
@db-waltz
Primary Measurable Ratings
4e75169 
- ratings browser for related measurables
  - optimised query to test if worth showing the section

#CTCTOWALTZ-2746
finos#6635
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jun 21, 2023
@db-waltz
Primary Measurable Ratings
1d7c755 
- ratings browser for related measurables
  - optimised query to test if worth showing the section

#CTCTOWALTZ-2746
finos#6635
@davidwatkins73 davidwatkins73 mentioned this issue Jun 21, 2023
Merged
@davidwatkins73 davidwatkins73 added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Jun 24, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 25, 2023
@davidwatkins73
Measurable rating isPrimary editor
e0a5204 
- added change log auditing

finos#6635
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 25, 2023
@davidwatkins73
Measurable rating isPrimary editor
d2fabef 
- added change log auditing
- removing deprecated code

finos#6635
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.51, 1.51 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Projects
None yet
Milestone
1.51
Development

No branches or pull requests
1 participant
@davidwatkins73