Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waltz needs better 'back button' support #6657

Closed
davidwatkins73 opened this issue Jun 25, 2023 · 1 comment
Closed

Waltz needs better 'back button' support #6657

davidwatkins73 opened this issue Jun 25, 2023 · 1 comment
Assignees
@jessica-woodland-scott-db
Labels
exploration This task may produce no results and is for information gathering fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Milestone
1.51

Comments

@davidwatkins73
Copy link
Member

Description

We seem to have a problem with window.history.replaceState, it writes entries in the history which seem to block the back button from working correctly.

The code is in section-store and is only really needed to update the query param with a list of open sections. In turn this is only needed so the url can be sent to others and the approriate sections will open. After some experimentation it seems as if we can remove that feature and instead us a more straightforward sharing mechanism, where a shareable url is copied to the clip board.

Resourcing

We intend to contribute this feature
@davidwatkins73 davidwatkins73 added the exploration This task may produce no results and is for information gathering label Jun 25, 2023
@davidwatkins73 davidwatkins73 added this to the wip : 1.51 milestone Jun 25, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jun 25, 2023
@davidwatkins73
Better back btn support
1707eb4 
We seem to have a problem with window.history.replaceState, it writes entries in the history which seem to block the back button from working correctly.

The code is in section-store and is only really needed to update the query param with a list of open sections. In turn this is only needed so the url can be sent to others and the appropriate sections will open.

After some experimentation it seems as if we can remove that feature and instead us a more straightforward sharing mechanism, where a shareable url is copied to the clip board.

finos#6657
@davidwatkins73 davidwatkins73 mentioned this issue Jun 25, 2023
Merged
@davidwatkins73
Copy link
Member Author

image

@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Jun 25, 2023
@jessica-woodland-scott-db jessica-woodland-scott-db added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Jun 26, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.51, 1.51 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessica-woodland-scott-db jessica-woodland-scott-db

Labels
exploration This task may produce no results and is for information gathering fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Projects
None yet
Milestone
1.51
Development

No branches or pull requests
2 participants
@davidwatkins73 @jessica-woodland-scott-db