Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure code builds on jdk 9+ #6678

Closed
davidwatkins73 opened this issue Jul 13, 2023 · 2 comments
Closed

Ensure code builds on jdk 9+ #6678

davidwatkins73 opened this issue Jul 13, 2023 · 2 comments
Assignees
@davidwatkins73
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing task Not directly feature related (i.e. dependency upgrade, docs, etc)
Milestone
1.52

Comments

@davidwatkins73
Copy link
Member

davidwatkins73 commented Jul 13, 2023 •
edited
Loading

Description

Main problem is import org.jooq.* which brings in the Record class. Java 9+ added Records to the core language and added a java.lang.Record. Javac is unable to determine which Record class it should be using and fails. Solution is simple, we need to ensure all usages of org.jooq.Record are via a specifc import statement (not a wildcard).

Note, this does not mean we will be using features unavailable in java 8 as we need to maintain backwards compatability.

Resourcing

We intend to implement this task
@davidwatkins73 davidwatkins73 added the task Not directly feature related (i.e. dependency upgrade, docs, etc) label Jul 13, 2023
@davidwatkins73 davidwatkins73 added this to the wip : 1.52 milestone Jul 13, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jul 13, 2023
@davidwatkins73
Removing wild card imports of org.jooq.Record
e881a2c 
finos#6678
@davidwatkins73 davidwatkins73 self-assigned this Jul 13, 2023
@davidwatkins73 davidwatkins73 mentioned this issue Jul 13, 2023
Merged
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jul 14, 2023
@davidwatkins73
Removing wild card imports of org.jooq.Record
7efbead 
finos#6678
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Jul 14, 2023
@davidwatkins73
Copy link
Member Author

Note, this does not mean we will be using features unavailable in java 8 as we need to maintain backwards compatability.

davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jul 14, 2023
@davidwatkins73
Removing wild card imports of org.jooq.Record
e8be662 
finos#6678
@davidwatkins73
Copy link
Member Author

image

davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Jul 14, 2023
@davidwatkins73
Removing wild card imports of org.jooq.Record
423c614 
finos#6678
@davidwatkins73 davidwatkins73 mentioned this issue Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing task Not directly feature related (i.e. dependency upgrade, docs, etc)
Projects
None yet
Milestone
1.52
Development

No branches or pull requests
2 participants
@davidwatkins73 @jessica-woodland-scott-db