Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Admin: bulk permissions operation screen should allow for a comment to be set #6681

Closed
davidwatkins73 opened this issue Jul 17, 2023 · 0 comments · Fixed by #6704
Closed

User Admin: bulk permissions operation screen should allow for a comment to be set #6681

davidwatkins73 opened this issue Jul 17, 2023 · 0 comments · Fixed by #6704
Labels
good first issue An issue suitable for new project collaborators noteworthy probably worth mentioning in release notes
Milestone
1.53

Comments

@davidwatkins73
Copy link
Member

davidwatkins73 commented Jul 17, 2023 •
edited
Loading

When updating user permissions the individual update page allows for a comment to be added to the changelog for the person (e.g. 'adding permission xyz because user abc requested it on their behalf')

The new bulk user permission screen does not allow for comments. This change should either

  • add a comment per operation (line)
  • add a 'global' comment which applies to all operations
  • a combination of the above, global + per-op overrides

Suggest going with the first variant initially as it is most flexible.

Tagging with good first issue as this is localized to only a couple of areas in the code base:

  • Java

    • org.finos.waltz.model.user
    • org.finos.waltz.web.endpoints.api.UserEndpoint
    • org.finos.waltz.service.user.UserRoleService#bulkUpload

  • JS

    • waltz-ng/client/user/svelte/UserBulkEditor.svelte
@davidwatkins73 davidwatkins73 added this to the todo : 1.52 milestone Jul 17, 2023
@davidwatkins73 davidwatkins73 added the good first issue An issue suitable for new project collaborators label Jul 17, 2023
@davidwatkins73 davidwatkins73 changed the title User Admin: bulk operation screen should allow for a comment to be set User Admin: bulk permissions operation screen should allow for a comment to be set Jul 17, 2023
@ralphmensah ralphmensah mentioned this issue Aug 11, 2023
Merged
@davidwatkins73 davidwatkins73 added the noteworthy probably worth mentioning in release notes label Aug 14, 2023
@davidwatkins73 davidwatkins73 modified the milestones: wip : 1.55.2, 1.54, 1.53 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue suitable for new project collaborators noteworthy probably worth mentioning in release notes
Projects
None yet
Milestone
1.53
Development

Successfully merging a pull request may close this issue.

6681:should allow for comments in bulk permissions screen ralphmensah/waltz
1 participant
@davidwatkins73