Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6406: Ensure data type list is sorted on flow details popup #6689

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

zxy994
Copy link
Contributor

@zxy994 zxy994 commented Jul 20, 2023

#6406
This draft PR aims to address the data type list sorting on flow details popup. The added screenshots to the issue were helpful in finding the popup menu. Despite, this PR requires testing with a node mapping to multiple data types.

@zxy994 zxy994 marked this pull request as ready for review July 21, 2023 09:38
Copy link
Member

@davidwatkins73 davidwatkins73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for the PR. We will hold off merging it until next week as we are just putting the final touches to the 1.52 build and don't want to add last minute changes (no matter how small).

I'll be hols for a couple of weeks. However @JWoodland-Scott would be happy to help if you wanted to pick up another (larger?) issue.

Thanks again,
Dave

@davidwatkins73 davidwatkins73 merged commit 83c0311 into finos:master Aug 2, 2023
@davidwatkins73
Copy link
Member

I've merged this now and it will be release in the 1.53 release.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants