Simplify inverse trigonometric constants

fintarin · Aug 10, 2023 · 2185b53 · 2185b53
1 parent 91959d4
commit 2185b53
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 2 deletions.
diff --git a/src/fintamath/expressions/unary/InvTrigExpression.cpp b/src/fintamath/expressions/unary/InvTrigExpression.cpp
@@ -14,8 +14,50 @@ InvTrigExpression::SimplifyFunctionsVector InvTrigExpression::getFunctionsForPos
 }
 
 ArgumentPtr InvTrigExpression::constantsSimplify(const IFunction & /*func*/, const ArgumentPtr & /*rhs*/) {
-  // TODO! implement
-  return {};
+  if (*rhs == Pi()) {
+    return trigTableSimplify(func, 1);
+  }
+
+  if (*rhs == *makeExpr(Neg(), Pi())) {
+    return trigTableSimplify(func, -1);
+  }
+
+  const auto rhsExpr = cast<IExpression>(rhs);
+  if (!rhsExpr || !is<Mul>(rhsExpr->getFunction())) {
+    return {};
+  }
+
+  const auto rhsChildren = rhsExpr->getChildren();
+  if (rhsChildren.size() != 2 || !is<Pi>(rhsChildren.back())) {
+    return {};
+  }
+
+  const auto rhsChildRat = cast<Rational>(convert(Rational(), *rhsChildren.front()));
+  if (!rhsChildRat) {
+    return {};
+  }
+
+  return trigTableSimplify(func, *rhsChildRat);
+}
+
+ArgumentPtr InvTrigExpression::invTrigTableSimplify(const IFunction &func, const Rational &rhs) {
+
+}
+
+ArgumentPtr InvTrigExpression::invTrigTableAsinSimplify(const Rational &rhs) {
+
+}
+
+ArgumentPtr InvTrigExpression::invTrigTableAcosSimplify(const Rational &rhs) {
+
+}
+
+ArgumentPtr InvTrigExpression::invTrigTableAtanSimplify(const Rational &rhs) {
+
+}
+
+ArgumentPtr InvTrigExpression::invTrigTableAcotSimplify(const Rational &rhs) {
+
 }
 
 }
diff --git a/src/fintamath/expressions/unary/InvTrigExpression.hpp b/src/fintamath/expressions/unary/InvTrigExpression.hpp
@@ -4,6 +4,8 @@
 
 namespace fintamath {
 
+class Rational;
+
 class InvTrigExpression : public IUnaryExpressionCRTP<InvTrigExpression, true> {
 public:
   explicit InvTrigExpression(const IFunction &inFunc, const ArgumentPtr &inChild);
@@ -17,6 +19,16 @@ class InvTrigExpression : public IUnaryExpressionCRTP<InvTrigExpression, true> {
 
 private:
   static ArgumentPtr constantsSimplify(const IFunction &func, const ArgumentPtr &rhs);
+
+  static ArgumentPtr invTrigTableSimplify(const IFunction &func, const Rational &rhs);
+
+  static ArgumentPtr invTrigTableAsinSimplify(const Rational &rhs);
+
+  static ArgumentPtr invTrigTableAcosSimplify(const Rational &rhs);
+
+  static ArgumentPtr invTrigTableAtanSimplify(const Rational &rhs);
+
+  static ArgumentPtr invTrigTableAcotSimplify(const Rational &rhs);
 };
 
 }
diff --git a/src/fintamath/expressions/unary/TrigExpression.cpp b/src/fintamath/expressions/unary/TrigExpression.cpp
@@ -85,6 +85,7 @@ ArgumentPtr TrigExpression::constantsSimplify(const IFunction &func, const Argum
   if (!rhsChildRat) {
     return {};
   }
+
   return trigTableSimplify(func, *rhsChildRat);
 }