Refactor logic functions

fintarin · Aug 7, 2023 · 682dc4f · 682dc4f
1 parent 599ed2e
commit 682dc4f
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 6 deletions.
diff --git a/src/fintamath/functions/logic/And.cpp b/src/fintamath/functions/logic/And.cpp
@@ -3,7 +3,10 @@
 namespace fintamath {
 
 std::unique_ptr<IMathObject> And::call(const ArgumentsRefVector &argsVect) const {
-  return std::make_unique<Boolean>(cast<Boolean>(argsVect.front().get()) && cast<Boolean>(argsVect.back().get()));
+  const auto &lhs = cast<Boolean>(argsVect.front().get());
+  const auto &rhs = cast<Boolean>(argsVect.back().get());
+
+  return std::make_unique<Boolean>(lhs && rhs);
 }
 
 }
diff --git a/src/fintamath/functions/logic/Equiv.cpp b/src/fintamath/functions/logic/Equiv.cpp
@@ -3,7 +3,10 @@
 namespace fintamath {
 
 std::unique_ptr<IMathObject> Equiv::call(const ArgumentsRefVector &argsVect) const {
-  return std::make_unique<Boolean>(cast<Boolean>(argsVect.front().get()) == cast<Boolean>(argsVect.back().get()));
+  const auto &lhs = cast<Boolean>(argsVect.front().get());
+  const auto &rhs = cast<Boolean>(argsVect.back().get());
+
+  return std::make_unique<Boolean>(lhs == rhs);
 }
 
 }
diff --git a/src/fintamath/functions/logic/Impl.cpp b/src/fintamath/functions/logic/Impl.cpp
@@ -3,7 +3,10 @@
 namespace fintamath {
 
 std::unique_ptr<IMathObject> Impl::call(const ArgumentsRefVector &argsVect) const {
-  return std::make_unique<Boolean>(!cast<Boolean>(argsVect.front().get()) || cast<Boolean>(argsVect.back().get()));
+  const auto &lhs = cast<Boolean>(argsVect.front().get());
+  const auto &rhs = cast<Boolean>(argsVect.back().get());
+
+  return std::make_unique<Boolean>(!lhs || rhs);
 }
 
 }
diff --git a/src/fintamath/functions/logic/Nequiv.cpp b/src/fintamath/functions/logic/Nequiv.cpp
@@ -3,7 +3,10 @@
 namespace fintamath {
 
 std::unique_ptr<IMathObject> Nequiv::call(const ArgumentsRefVector &argsVect) const {
-  return std::make_unique<Boolean>(cast<Boolean>(argsVect.front().get()) != cast<Boolean>(argsVect.back().get()));
+  const auto &lhs = cast<Boolean>(argsVect.front().get());
+  const auto &rhs = cast<Boolean>(argsVect.back().get());
+
+  return std::make_unique<Boolean>(lhs != rhs);
 }
 
 }
diff --git a/src/fintamath/functions/logic/Not.cpp b/src/fintamath/functions/logic/Not.cpp
@@ -3,7 +3,9 @@
 namespace fintamath {
 
 std::unique_ptr<IMathObject> Not::call(const ArgumentsRefVector &argsVect) const {
-  return std::make_unique<Boolean>(!cast<Boolean>(argsVect.front().get()));
+  const auto &rhs = cast<Boolean>(argsVect.front().get());
+
+  return std::make_unique<Boolean>(!rhs);
 }
 
 }
diff --git a/src/fintamath/functions/logic/Or.cpp b/src/fintamath/functions/logic/Or.cpp
@@ -3,7 +3,10 @@
 namespace fintamath {
 
 std::unique_ptr<IMathObject> Or::call(const ArgumentsRefVector &argsVect) const {
-  return std::make_unique<Boolean>(cast<Boolean>(argsVect.front().get()) || cast<Boolean>(argsVect.back().get()));
+  const auto &lhs = cast<Boolean>(argsVect.front().get());
+  const auto &rhs = cast<Boolean>(argsVect.back().get());
+
+  return std::make_unique<Boolean>(lhs || rhs);
 }
 
 }